Merge pull request #22 from appuio/fix/session-leak

glrf · web-flow · commit 71d1bf3edfbb · 2022-04-27T13:21:35.000+02:00
Fix Keycloak session leak
diff --git a/internal/pkg/keycloak/client.go b/internal/pkg/keycloak/client.go
@@ -37,6 +37,8 @@ func (g *gocloakClient) GetUsers(ctx context.Context, realm string, params goclo
 	if err != nil {
 		return nil, fmt.Errorf("failed binding to keycloak: %w", err)
 	}
+	// `admin-cli` is the magic client used when authenticating to the admin API
+	defer g.client.LogoutPublicClient(ctx, "admin-cli", g.loginRealm, token.AccessToken, token.RefreshToken)
 
 	return g.client.GetUsers(ctx, token.AccessToken, realm, params)
 }

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,8 @@ func (g *gocloakClient) GetUsers(ctx context.Context, realm string, params goclo`
`37`	`37`	`if err != nil {`
`38`	`38`	`return nil, fmt.Errorf("failed binding to keycloak: %w", err)`
`39`	`39`	`}`
	`40`	+ // `admin-cli` is the magic client used when authenticating to the admin API
	`41`	`+ defer g.client.LogoutPublicClient(ctx, "admin-cli", g.loginRealm, token.AccessToken, token.RefreshToken)`
`40`	`42`
`41`	`43`	`return g.client.GetUsers(ctx, token.AccessToken, realm, params)`
`42`	`44`	`}`