Skip to content

Commit 33023b0

Browse files
committed
fix: kinematics units conversion
1 parent 42f019f commit 33023b0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/Arduino_AlvikCarrier.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,7 @@ void Arduino_AlvikCarrier::rotate(const float angle){
637637

638638

639639
void Arduino_AlvikCarrier::move(const float distance){
640-
float initial_travel=1000.0*kinematics->getTravel();
640+
float initial_travel=kinematics->getTravel();
641641
float final_travel=abs(distance)+initial_travel;
642642
float error=abs(distance);
643643
unsigned long t=millis();
@@ -648,7 +648,7 @@ void Arduino_AlvikCarrier::move(const float distance){
648648
updateMotors();
649649
kinematics->inverse(motor_control_left->getRPM(),motor_control_right->getRPM());
650650
kinematics->updatePose();
651-
error=final_travel-1000.0*kinematics->getTravel();
651+
error=final_travel-kinematics->getTravel();
652652
Serial.println(kinematics->getTravel());
653653
}
654654
if (distance>0){

src/robotics/kinematics.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ class Kinematics{
9898
delta_travel=0.0;
9999
travel=0.0;
100100

101-
control_period=_control_period*0.001; // convert ms to s
101+
control_period = _control_period;
102102
}
103103

104104
void forward(const float linear, const float angular){

0 commit comments

Comments
 (0)