Apply suggestions from code review

Add more const correctness

Co-authored-by: Alexander Entinger <[email protected]>

Author: maxgerhardt

libraries/OPAMP/examples/start_opamp/start_opamp.ino

@@ -10,7 +10,7 @@ void setup () {
   if (!OPAMP.begin(OPAMP_SPEED_HIGHSPEED)) {
     Serial.println("Failed to start OPAMP!");
   }
-  bool isRunning = OPAMP.isRunning(0);
+  bool const isRunning = OPAMP.isRunning(0);
   if (isRunning) {
     Serial.println("OPAMP running on channel 0!");
   } else {

libraries/OPAMP/src/OPAMP.cpp

@@ -81,11 +81,13 @@ bool OpampClass::begin() {
     return this->begin(OPAMP_SPEED_HIGHSPEED);
 }
 
-bool OpampClass::begin(OpampSpeedMode speed) {
+bool OpampClass::begin(OpampSpeedMode const speed) {
+
     return this->begin(1u << ARDUINO_UNO_R4_DEFAULT_OPAMP_CHANNEL, speed);
 }
 
-bool OpampClass::begin(uint8_t const channel_mask, OpampSpeedMode speed) {
+bool OpampClass::begin(uint8_t const channel_mask, OpampSpeedMode const speed) {
+
     if (!initPins(channel_mask)) {
         return false;
     }

libraries/OPAMP/src/OPAMP.h

@@ -33,9 +33,11 @@ class OpampClass {
     /* startup the OPAMP on channel 0 in high-speed mode */
     bool begin();
     /* startup the OPAMP on channel 0 with specific mode */
-    bool begin(OpampSpeedMode speed);
+    bool begin(OpampSpeedMode const speed);
+
     /* startup the OPAMP with arbitrary channel mask */
-    bool begin(uint8_t const channel_mask, OpampSpeedMode speed);
+    bool begin(uint8_t const channel_mask, OpampSpeedMode const speed);
+
     /* stop all OPAMP channels */
     void end();
     /* stop specific OPAMP channel(s) */
@@ -46,7 +48,8 @@ class OpampClass {
     /* initializes OPAMP pins for given channel(s) */
     bool initPins(uint8_t const channel_mask);
     /* activates OPAMP for given speed and channel(s) */
-    void initOpamp(OpampSpeedMode speed, uint8_t const channel_mask);
+    void initOpamp(OpampSpeedMode const speed, uint8_t const channel_mask);
+
 };
 
 extern OpampClass OPAMP;