wip

Author: alessio-perugini

internal/integrationtest/lib/lib_test.go

@@ -20,6 +20,7 @@ import (
 	"fmt"
 	"io"
 	"net/http"
+	"os"
 	"runtime"
 	"strings"
 	"testing"
@@ -31,6 +32,7 @@ import (
 	"github.com/go-git/go-git/v5/plumbing/object"
 	"github.com/stretchr/testify/require"
 	"go.bug.st/testifyjson/requirejson"
+	"gopkg.in/src-d/go-git.v4/plumbing"
 )
 
 func TestLibUpgradeCommand(t *testing.T) {
@@ -650,36 +652,22 @@ func TestInstallWithGitUrl(t *testing.T) {
 }
 
 func TestInstallWithGitUrlFragmentAsBranch(t *testing.T) {
-	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
-	defer env.CleanUp()
-
-	// Initialize configs to enable --git-url flag
-	envVar := cli.GetDefaultEnv()
-	envVar["ARDUINO_ENABLE_UNSAFE_LIBRARY_INSTALL"] = "true"
-	_, _, err := cli.RunWithCustomEnv(envVar, "config", "init", "--dest-dir", ".")
-	require.NoError(t, err)
-
-	libInstallDir := cli.SketchbookDir().Join("libraries", "WiFi101")
-	// Verifies library is not already installed
-	require.NoDirExists(t, libInstallDir.String())
-
-	gitUrl := "https://github.com/arduino-libraries/WiFi101.git"
-
-	// Test that a bad ref fails
-	_, _, err = cli.Run("lib", "install", "--git-url", gitUrl+"#x-ref-does-not-exist", "--config-file", "arduino-cli.yaml")
-	require.Error(t, err)
-
-	// Verifies library is installed in expected path
-	_, _, err = cli.Run("lib", "install", "--git-url", gitUrl+"#0.16.0", "--config-file", "arduino-cli.yaml")
-	require.NoError(t, err)
-	require.DirExists(t, libInstallDir.String())
-
-	// Reinstall library at an existing ref
-	_, _, err = cli.Run("lib", "install", "--git-url", gitUrl+"#master", "--config-file", "arduino-cli.yaml")
+	repo, err := git.PlainClone(t.TempDir(), false, &git.CloneOptions{
+		URL:      "https://github.com/arduino-libraries/WiFi101.git#0.16.0",
+		Depth:    0,
+		Progress: os.Stdout,
+	})
 	require.NoError(t, err)
-
-	// Verifies library remains installed
-	require.DirExists(t, libInstallDir.String())
+	ref := plumbing.Revision("0.16.0")
+	if ref != "" {
+		if h, err := repo.ResolveRevision(ref); err != nil {
+			require.NoError(t, err)
+		} else if w, err := repo.Worktree(); err != nil {
+			require.NoError(t, err)
+		} else if err := w.Checkout(&git.CheckoutOptions{Hash: plumbing.NewHash(h.String())}); err != nil {
+			require.NoError(t, err)
+		}
+	}
 }
 
 func TestUpdateIndex(t *testing.T) {