Code refactoring

Author: rjtokenring

cli/ota/encode.go

@@ -31,8 +31,8 @@ import (
 )
 
 type encodeBinaryFlags struct {
-	deviceID string
-	file     string
+	FQBN 	string
+	file    string
 }
 
 func initEncodeBinaryCommand() *cobra.Command {
@@ -48,7 +48,7 @@ func initEncodeBinaryCommand() *cobra.Command {
 			}
 		},
 	}
-	uploadCommand.Flags().StringVarP(&flags.deviceID, "device-id", "d", "", "Device ID")
+	uploadCommand.Flags().StringVarP(&flags.FQBN, "fqbn", "b", "", "Device fqbn")
 	uploadCommand.Flags().StringVarP(&flags.file, "file", "", "", "Binary file (.bin) to be encoded")
 	uploadCommand.MarkFlagRequired("device-id")
 	uploadCommand.MarkFlagRequired("file")
@@ -64,8 +64,8 @@ func runEncodeCommand(flags *encodeBinaryFlags) error {
 	}
 
 	params := &ota.EncodeParams{
-		DeviceID: flags.deviceID,
-		File:     flags.file,
+		FQBN: 	flags.FQBN,
+		File:   flags.file,
 	}
 	otafile, err := ota.Encode(context.TODO(), params, cred)
 	if err != nil {

command/ota/encode.go

@@ -23,36 +23,25 @@ import (
 	"os"
 
 	"github.com/arduino/arduino-cloud-cli/config"
-	"github.com/arduino/arduino-cloud-cli/internal/iot"
 )
 
 type EncodeParams struct {
-	DeviceID string
+	FQBN 	 string
 	File     string
 }
 
 // Encode command is used to encode a firmware OTA
 func Encode(ctx context.Context, params *EncodeParams, cred *config.Credentials) (*string, error) {
-	iotClient, err := iot.NewClient(cred)
-	if err != nil {
-		return nil, err
-	}
-
-	dev, err := iotClient.DeviceShow(ctx, params.DeviceID)
-	if err != nil {
-		return nil, err
-	}
-
 	otaFile := fmt.Sprintf("%s.ota", params.File)
-	_, err = os.Stat(otaFile)
+	_, err := os.Stat(otaFile)
 	if err == nil {
 		// file already exists, we need to delete it
 		if err = os.Remove(otaFile); err != nil {
 			return nil, fmt.Errorf("%s: %w", "cannot remove .ota file", err)
 		}
 	}
 
-	err = Generate(params.File, otaFile, dev.Fqbn)
+	err = Generate(params.File, otaFile, params.FQBN)
 	if err != nil {
 		return nil, fmt.Errorf("%s: %w", "cannot generate .ota file", err)
 	}