Skip to content

Commit f71a4c1

Browse files
committed
chore: address PR comments.
1 parent 3e8caa2 commit f71a4c1

File tree

2 files changed

+22
-9
lines changed

2 files changed

+22
-9
lines changed

google-cloud-spanner/src/main/java/com/google/cloud/spanner/Spanner.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ public interface Spanner extends Service<SpannerOptions>, AutoCloseable {
3030
/**
3131
* Returns a {@code DatabaseAdminClient} to execute admin operations on Cloud Spanner databases.
3232
*
33-
* @return
34-
* @deprecated Use {@link #databaseAdminClient()} instead.
33+
* @return {@code DatabaseAdminClient}
3534
*/
3635
/*
3736
* <!--SNIPPET get_dbadmin_client-->
@@ -42,7 +41,6 @@ public interface Spanner extends Service<SpannerOptions>, AutoCloseable {
4241
* }</pre>
4342
* <!--SNIPPET get_dbadmin_client-->
4443
*/
45-
@Deprecated
4644
DatabaseAdminClient getDatabaseAdminClient();
4745

4846
/**
@@ -68,7 +66,6 @@ default com.google.cloud.spanner.admin.database.v1.DatabaseAdminClient databaseA
6866
* Returns an {@code InstanceAdminClient} to execute admin operations on Cloud Spanner instances.
6967
*
7068
* @return {@code InstanceAdminClient}
71-
* @deprecated Use {@link #instanceAdminClient()}} instead.
7269
*/
7370
/*
7471
* <!--SNIPPET get_instance_admin_client-->
@@ -79,7 +76,6 @@ default com.google.cloud.spanner.admin.database.v1.DatabaseAdminClient databaseA
7976
* }</pre>
8077
* <!--SNIPPET get_instance_admin_client-->
8178
*/
82-
@Deprecated
8379
InstanceAdminClient getInstanceAdminClient();
8480

8581
/**

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerImpl.java

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,16 @@ private static String nextDatabaseClientId(DatabaseId databaseId) {
101101
@GuardedBy("this")
102102
private final Map<DatabaseId, DatabaseClientImpl> dbClients = new HashMap<>();
103103

104+
@GuardedBy("this")
105+
private final Map<
106+
InstanceAdminStub, com.google.cloud.spanner.admin.instance.v1.InstanceAdminClient>
107+
instanceAdminClients = new HashMap<>();
108+
109+
@GuardedBy("this")
110+
private final Map<
111+
DatabaseAdminStub, com.google.cloud.spanner.admin.database.v1.DatabaseAdminClient>
112+
databaseAdminClients = new HashMap<>();
113+
104114
private final CloseableExecutorProvider asyncExecutorProvider;
105115

106116
@GuardedBy("this")
@@ -109,6 +119,9 @@ private static String nextDatabaseClientId(DatabaseId databaseId) {
109119
private final DatabaseAdminClient dbAdminClient;
110120
private final InstanceAdminClient instanceClient;
111121

122+
private final com.google.cloud.spanner.admin.database.v1.DatabaseAdminClient databaseAdminClient;
123+
private final com.google.cloud.spanner.admin.instance.v1.InstanceAdminClient instanceAdminClient;
124+
112125
/**
113126
* Exception class used to track the stack trace at the point when a Spanner instance is closed.
114127
* This exception will be thrown if a user tries to use any resources that were returned by this
@@ -137,6 +150,12 @@ static final class ClosedException extends RuntimeException {
137150
this.dbAdminClient = new DatabaseAdminClientImpl(options.getProjectId(), gapicRpc);
138151
this.instanceClient =
139152
new InstanceAdminClientImpl(options.getProjectId(), gapicRpc, dbAdminClient);
153+
this.databaseAdminClient =
154+
com.google.cloud.spanner.admin.database.v1.DatabaseAdminClient.create(
155+
gapicRpc.getDatabaseAdminStub());
156+
this.instanceAdminClient =
157+
com.google.cloud.spanner.admin.instance.v1.InstanceAdminClient.create(
158+
gapicRpc.getInstanceAdminStub());
140159
}
141160

142161
SpannerImpl(SpannerOptions options) {
@@ -211,8 +230,7 @@ public DatabaseAdminClient getDatabaseAdminClient() {
211230

212231
@Override
213232
public com.google.cloud.spanner.admin.database.v1.DatabaseAdminClient databaseAdminClient() {
214-
DatabaseAdminStub databaseAdminStub = gapicRpc.getDatabaseAdminStub();
215-
return com.google.cloud.spanner.admin.database.v1.DatabaseAdminClient.create(databaseAdminStub);
233+
return databaseAdminClient;
216234
}
217235

218236
@Override
@@ -222,8 +240,7 @@ public InstanceAdminClient getInstanceAdminClient() {
222240

223241
@Override
224242
public com.google.cloud.spanner.admin.instance.v1.InstanceAdminClient instanceAdminClient() {
225-
InstanceAdminStub instanceAdminStub = gapicRpc.getInstanceAdminStub();
226-
return com.google.cloud.spanner.admin.instance.v1.InstanceAdminClient.create(instanceAdminStub);
243+
return instanceAdminClient;
227244
}
228245

229246
@Override

0 commit comments

Comments
 (0)