Fix DHCP server Uninitialized memory read

Removed not needed boolean and structure
Fixed the length calculation when address allocation fails

Author: Mika Tervonen

source/DHCPv6_Server/DHCPv6_Server_service.c

@@ -88,36 +88,32 @@ static void DHCP_server_service_timer_stop(void)
 int DHCPv6_server_respond_client(dhcpv6_gua_server_entry_s *serverBase, dhcpv6_reply_packet_s *replyPacket, dhcp_ia_non_temporal_params_t *dhcp_ia_non_temporal_params, dhcpv6_gua_response_t *response, bool allocateNew)
 {
     dhcpv6_allocated_address_t *dhcp_allocated_address = NULL;
-    dhcpv6_ia_non_temporal_address_s nonTemporalAddress;
-    bool address_allocated = false;
     //Validate Client DUID
     dhcp_link_options_params_t clientDUID;
+
     if (libdhcpv6_get_link_address_from_duid(replyPacket->clientDUID.duid, replyPacket->clientDUID.duid_length, replyPacket->clientDUID.type, &clientDUID) == 0) {
         dhcp_allocated_address = libdhcpv6_address_allocate(serverBase, clientDUID.link_id, clientDUID.link_type, dhcp_ia_non_temporal_params->iaId, dhcp_ia_non_temporal_params->T0, dhcp_ia_non_temporal_params->T1, allocateNew);
     }
     if (dhcp_allocated_address) {
-        address_allocated = true;
-        nonTemporalAddress.requestedAddress = dhcp_allocated_address->nonTemporalAddress;
-        nonTemporalAddress.validLifeTime = dhcp_allocated_address->lifetime;
-        nonTemporalAddress.preferredLifeTime = dhcp_allocated_address->preferredLifetime;
-
         if (serverBase->addCb) {
             dhcp_address_cache_update_t update_info;
             update_info.allocatedAddress = dhcp_allocated_address->nonTemporalAddress;
             update_info.allocatedNewAddress = allocateNew;
-            update_info.validLifeTime = nonTemporalAddress.validLifeTime;
+            update_info.validLifeTime = dhcp_allocated_address->lifetime;
 
             if (!serverBase->addCb(serverBase->interfaceId, &update_info, serverBase->guaPrefix)) {
-                address_allocated = false;
                 libdhcpv6_address_delete(serverBase, dhcp_allocated_address->nonTemporalAddress);
+                dhcp_allocated_address = NULL;
             }
         }
     }
 
-    response->responseLength = libdhcpv6_address_reply_message_len(replyPacket->clientDUID.duid_length, replyPacket->serverDUID.duid_length, 0, replyPacket->rapidCommit, address_allocated);
+    response->responseLength = libdhcpv6_address_reply_message_len(replyPacket->clientDUID.duid_length, replyPacket->serverDUID.duid_length, 0, replyPacket->rapidCommit, (dhcp_allocated_address != NULL));
     //Calculate DNS LIST and Vendor data lengths here
-    response->responseLength += libdhcpv6_dns_server_message_sizes(serverBase);
-    response->responseLength += libdhcpv6_vendor_data_message_sizes(serverBase);
+    if (dhcp_allocated_address) {
+        response->responseLength += libdhcpv6_dns_server_message_sizes(serverBase);
+        response->responseLength += libdhcpv6_vendor_data_message_sizes(serverBase);
+    }
 
     response->responsePtr = ns_dyn_mem_temporary_alloc(response->responseLength);
     if (response->responsePtr) {
@@ -126,9 +122,9 @@ int DHCPv6_server_respond_client(dhcpv6_gua_server_entry_s *serverBase, dhcpv6_r
         ptr = libdhcpv6_header_write(ptr, DHCPV6_REPLY_TYPE, replyPacket->transaction_ID);
         ptr = libdhcpv6_duid_option_write(ptr, DHCPV6_SERVER_ID_OPTION, &replyPacket->serverDUID); //16
         ptr = libdhcpv6_duid_option_write(ptr, DHCPV6_CLIENT_ID_OPTION, &replyPacket->clientDUID); //16
-        if (address_allocated) {
+        if (dhcp_allocated_address) {
             ptr = libdhcpv6_identity_association_option_write(ptr, replyPacket->iaId, replyPacket->T0, replyPacket->T1, true);
-            ptr = libdhcpv6_ia_address_option_write(ptr, nonTemporalAddress.requestedAddress, nonTemporalAddress.preferredLifeTime, nonTemporalAddress.validLifeTime);
+            ptr = libdhcpv6_ia_address_option_write(ptr, dhcp_allocated_address->nonTemporalAddress, dhcp_allocated_address->preferredLifetime, dhcp_allocated_address->lifetime);
             //Write DNS LIST and Vendor data here
             ptr = libdhcpv6_dns_server_message_writes(serverBase, ptr);
             ptr = libdhcpv6_vendor_data_message_writes(serverBase, ptr);