Fix ObjectDisposedException

Fix ObjectDisposedException in the Apple provider when using System.IdentityModel.Tokens.Jwt 5.5.0+.

Co-Authored-By: Anthony Yates <[email protected]>

Author: martincostello

Directory.Packages.props

@@ -12,10 +12,6 @@
     <PackageVersion Include="Microsoft.NetCore.Analyzers" Version="3.0.0" />
     <PackageVersion Include="Shouldly" Version="3.0.2" />
     <PackageVersion Include="StyleCop.Analyzers" Version="1.1.118" />
-
-    <!--
-      Cannot use later versions (5.5.0+) due to https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/1302.
-    -->
     <PackageVersion Include="System.IdentityModel.Tokens.Jwt" Version="5.4.0" />
   </ItemGroup>
 

src/AspNet.Security.OAuth.Apple/Internal/DefaultAppleClientSecretGenerator.cs

@@ -18,6 +18,11 @@ namespace AspNet.Security.OAuth.Apple.Internal
 {
     internal sealed class DefaultAppleClientSecretGenerator : AppleClientSecretGenerator
     {
+        private static readonly CryptoProviderFactory CryptoProviderFactory = new CryptoProviderFactory()
+        {
+            CacheSignatureProviders = false,
+        };
+
         private readonly ISystemClock _clock;
         private readonly ILogger _logger;
         private readonly AppleKeyStore _keyStore;
@@ -110,7 +115,13 @@ private static ECDsa CreateAlgorithm(byte[] keyBlob)
         private static SigningCredentials CreateSigningCredentials(string keyId, ECDsa algorithm)
         {
             var key = new ECDsaSecurityKey(algorithm) { KeyId = keyId };
-            return new SigningCredentials(key, SecurityAlgorithms.EcdsaSha256Signature);
+
+            // Use a custom CryptoProviderFactory so that keys are not cached and then disposed of, see below:
+            // https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/1302
+            return new SigningCredentials(key, SecurityAlgorithms.EcdsaSha256Signature)
+            {
+                CryptoProviderFactory = CryptoProviderFactory,
+            };
         }
     }
 }