Skip to content

Commit 24534b3

Browse files
author
Verdi March
committed
Fixed 2 tests: test_sklearn_with_all_parameters_via_run_args{,_called_twice}()
1 parent dac7ed3 commit 24534b3

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

tests/unit/test_processing.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ def test_sklearn_with_all_parameters_via_run_args(
155155
botocore_resolver.return_value.construct_endpoint.return_value = {"hostname": ECR_HOSTNAME}
156156

157157
processor = SKLearnProcessor(
158+
s3_prefix=MOCKED_S3_URI,
158159
role=ROLE,
159160
framework_version=sklearn_version,
160161
instance_type="ml.m4.xlarge",
@@ -175,6 +176,8 @@ def test_sklearn_with_all_parameters_via_run_args(
175176
sagemaker_session=sagemaker_session,
176177
)
177178

179+
# FIXME: to check FrameworkProcessor.get_run_args(), and possibly fix with
180+
# source_dir, dependencies.
178181
run_args = processor.get_run_args(
179182
code="/local/path/to/processing_code.py",
180183
inputs=_get_data_inputs_all_parameters(),
@@ -183,7 +186,7 @@ def test_sklearn_with_all_parameters_via_run_args(
183186
)
184187

185188
processor.run(
186-
code=run_args.code,
189+
entry_point=run_args.code,
187190
inputs=run_args.inputs,
188191
outputs=run_args.outputs,
189192
arguments=run_args.arguments,
@@ -192,7 +195,7 @@ def test_sklearn_with_all_parameters_via_run_args(
192195
experiment_config={"ExperimentName": "AnExperiment"},
193196
)
194197

195-
expected_args = _get_expected_args_all_parameters(processor._current_job_name)
198+
expected_args = _get_expected_args_all_parameters_modular_code(processor._current_job_name)
196199
sklearn_image_uri = (
197200
"246618743249.dkr.ecr.us-west-2.amazonaws.com/sagemaker-scikit-learn:{}-cpu-py3"
198201
).format(sklearn_version)
@@ -210,6 +213,7 @@ def test_sklearn_with_all_parameters_via_run_args_called_twice(
210213
botocore_resolver.return_value.construct_endpoint.return_value = {"hostname": ECR_HOSTNAME}
211214

212215
processor = SKLearnProcessor(
216+
s3_prefix=MOCKED_S3_URI,
213217
role=ROLE,
214218
framework_version=sklearn_version,
215219
instance_type="ml.m4.xlarge",
@@ -245,7 +249,7 @@ def test_sklearn_with_all_parameters_via_run_args_called_twice(
245249
)
246250

247251
processor.run(
248-
code=run_args.code,
252+
entry_point=run_args.code,
249253
inputs=run_args.inputs,
250254
outputs=run_args.outputs,
251255
arguments=run_args.arguments,
@@ -254,7 +258,7 @@ def test_sklearn_with_all_parameters_via_run_args_called_twice(
254258
experiment_config={"ExperimentName": "AnExperiment"},
255259
)
256260

257-
expected_args = _get_expected_args_all_parameters(processor._current_job_name)
261+
expected_args = _get_expected_args_all_parameters_modular_code(processor._current_job_name)
258262
sklearn_image_uri = (
259263
"246618743249.dkr.ecr.us-west-2.amazonaws.com/sagemaker-scikit-learn:{}-cpu-py3"
260264
).format(sklearn_version)

0 commit comments

Comments
 (0)