Skip to content

Commit 34f95bd

Browse files
committed
refactor: SKLearn fix comment & unused param
Add comment for the SKLearnProcessor multiple instances fix and remove the now-unused function parameter. Merge remote-tracking branch 'verdi/pr-framework-processor-round-02' into feat/fw-processor
1 parent 8ec3226 commit 34f95bd

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/sagemaker/processing.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1306,7 +1306,7 @@ def __init__(
13061306
self.py_version = py_version
13071307

13081308
image_uri, base_job_name = self._pre_init_normalization(
1309-
instance_count, instance_type, image_uri, base_job_name, sagemaker_session
1309+
instance_type, image_uri, base_job_name, sagemaker_session
13101310
)
13111311

13121312
super().__init__(
@@ -1330,7 +1330,6 @@ def __init__(
13301330

13311331
def _pre_init_normalization(
13321332
self,
1333-
instance_count: int,
13341333
instance_type: str,
13351334
image_uri: Optional[str] = None,
13361335
base_job_name: Optional[str] = None,
@@ -1355,7 +1354,7 @@ def _pre_init_normalization(
13551354
entry_point="",
13561355
role="",
13571356
enable_network_isolation=False,
1358-
instance_count=1,
1357+
instance_count=1, # SKLearn estimator explicitly disables instance_count>1
13591358
sagemaker_session=sagemaker_session,
13601359
)
13611360
image_uri = est.training_image_uri()

0 commit comments

Comments
 (0)