feat: cookie authentication #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepio
reviewed
Oct 24, 2022
|
Custom checklist for PR (for some reason the template is missing in this PR): edit: see OP |
rescribet
force-pushed
the
cookie-authentication
branch
2 times, most recently
from
58e4726 to
fce69d1
Compare
|
You probably mean the changelog? That already has a new entry with the ticket number. |
|
From what I can tell the test should succeed, but this PR isn't tested against that version of the server. |
Yes we can ignore this E2E test, as this uses the master docker build. The rust PR E2E must succeed, though. |
4 tasks
rescribet
force-pushed
the
cookie-authentication
branch
from
fce69d1 to
4733819
Compare
joepio
force-pushed
the
cookie-authentication
branch
from
ad61fbc to
f701476
Compare
rescribet
force-pushed
the
cookie-authentication
branch
from
f701476 to
24bd09d
Compare
joepio
force-pushed
the
cookie-authentication
branch
from
24bd09d to
cbab515
Compare
rescribet
force-pushed
the
cookie-authentication
branch
from
cbab515 to
76503da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.