Skip to content

Commit 15ce7f2

Browse files
authored
Change logging for tensorboard exports (aws#372)
* Change logging for tensorboard stuff * reword log messagE
1 parent 67ec576 commit 15ce7f2

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

tornasole/core/hook.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,11 @@ def __init__(
117117

118118
self.logger = logger
119119

120+
if self.tensorboard_dir is None:
121+
self.logger.info(
122+
f"`tensorboard_dir` has not been set. Disabling export of tensorboard summaries."
123+
)
124+
120125
if include_regex is not None:
121126
collection_manager.get(CollectionKeys.DEFAULT).include(include_regex)
122127
if CollectionKeys.DEFAULT not in self.include_collections:

tornasole/mxnet/hook.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,6 @@ def _export_model(self):
112112
tb_writer = self._maybe_get_tb_writer()
113113
if tb_writer:
114114
tb_writer.write_graph(_net2pb(self.model))
115-
else:
116-
self.logger.warning("Model export failed because hook.tensorboard_dir is None")
117115
except (RuntimeError, TypeError) as e:
118116
self.logger.warning(
119117
f"Could not export model graph for tensorboard "

tornasole/tensorflow/hook.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,8 +335,6 @@ def _export_model(self):
335335
tb_writer = self._maybe_get_tb_writer()
336336
if tb_writer:
337337
tb_writer.write_graph(self.graph.as_graph_def(add_shapes=True))
338-
else:
339-
self.logger.debug("Graph not exported because `hook.tensorboard_dir` is None")
340338
# don't close writer as it might be needed in the step that follows
341339
# else we will have to open the file again
342340

0 commit comments

Comments
 (0)