Skip to content

Commit 29dfdc7

Browse files
authored
Remove logging to file (aws#64)
* logger remove file * remove import
1 parent eb0fdef commit 29dfdc7

File tree

2 files changed

+23
-27
lines changed

2 files changed

+23
-27
lines changed

tornasole_core/tfevent/util.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
import numpy as np
44
import os, re
55
from tornasole_core.utils import get_immediate_subdirectories
6-
from tornasole_core.utils import logger
6+
from tornasole_core.utils import get_logger
7+
8+
logger = get_logger()
79

810
# hash value of ndarray.dtype is not the same as np.float class
911
# so we need to convert the type classes below to np.dtype object

tornasole_core/utils.py

Lines changed: 20 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -14,40 +14,34 @@ def flatten(lis):
1414
new_lis.append(item)
1515
return new_lis
1616

17-
logger = None
17+
_logger_level_set = False
1818

19-
def get_logger(path=os.getcwd()):
20-
global logger
21-
if logger is None:
22-
logger = logging.getLogger("tornasole")
23-
fh = logging.FileHandler(os.path.join(path, 'tornasole.log'))
19+
def get_logger():
20+
global _logger_level_set
21+
name = 'tornasole'
22+
if not _logger_level_set:
2423
log_level = os.environ.get('TORNASOLE_LOG_LEVEL', default='info')
2524
log_level = log_level.lower()
26-
2725
if log_level not in ['info', 'debug', 'warning', 'error', 'critical', 'off']:
2826
print('Invalid log level for TORNASOLE_LOG_LEVEL')
2927
log_level = 'info'
3028

3129
if log_level == 'off':
32-
logger.disabled = True
33-
elif log_level == 'critical':
34-
logger.setLevel(logging.CRITICAL)
35-
elif log_level == 'error':
36-
logger.setLevel(logging.ERROR)
37-
elif log_level == 'warning':
38-
logger.setLevel(logging.WARNING)
39-
elif log_level == 'info':
40-
logger.setLevel(logging.INFO)
41-
elif log_level == 'debug':
42-
logger.setLevel(logging.DEBUG)
43-
44-
fh.setFormatter(logging.Formatter('%(asctime)s - %(name)s - %(levelname)s - %(message)s'))
45-
logger.addHandler(fh)
46-
# logger.propagate = False
47-
return logger
48-
else:
49-
return logger
50-
30+
logging.getLogger(name).disabled = True
31+
else:
32+
if log_level == 'critical':
33+
level = logging.CRITICAL
34+
elif log_level == 'error':
35+
level = logging.ERROR
36+
elif log_level == 'warning':
37+
level = logging.WARNING
38+
elif log_level == 'info':
39+
level = logging.INFO
40+
elif log_level == 'debug':
41+
level = logging.DEBUG
42+
logging.getLogger(name).setLevel(level)
43+
_logger_level_set = True
44+
return logging.getLogger(name)
5145

5246
def get_immediate_subdirectories(a_dir):
5347
return [name for name in os.listdir(a_dir)

0 commit comments

Comments
 (0)