[swiftpm] Add tests for more settings cases

* Header file
* Package.swift file
* Unknown file/url

Author: benlangmuir

Tests/SKSwiftPMWorkspaceTests/SwiftPMWorkspaceTests.swift

@@ -117,6 +117,33 @@ final class SwiftPMWorkspaceTests: XCTestCase {
     check(aswift.asString, arguments: arguments)
   }
 
+  func testManifestArgs() {
+    // FIXME: should be possible to use InMemoryFileSystem.
+    let fs = localFileSystem
+    let tempDir = try! TemporaryDirectory(removeTreeOnDeinit: true)
+    try! fs.createFiles(root: tempDir.path, files: [
+      "pkg/Sources/lib/a.swift": "",
+      "pkg/Package.swift": """
+          // swift-tools-version:4.2
+          import PackageDescription
+          let package = Package(name: "a", products: [], dependencies: [],
+            targets: [.target(name: "lib", dependencies: [])])
+          """
+    ])
+    let packageRoot = tempDir.path.appending(component: "pkg")
+    let tr = ToolchainRegistry.shared
+    let ws = try! SwiftPMWorkspace(
+      workspacePath: packageRoot,
+      toolchainRegistry: tr,
+      fileSystem: fs)
+
+    let source = packageRoot.appending(component: "Package.swift")
+    let arguments = ws.settings(for: source.asURL, .swift)!.compilerArguments
+
+    check("-swift-version", "4.2", arguments: arguments)
+    check(source.asString, arguments: arguments)
+  }
+
   func testMultiFileSwift() {
     // FIXME: should be possible to use InMemoryFileSystem.
     let fs = localFileSystem
@@ -189,6 +216,36 @@ final class SwiftPMWorkspaceTests: XCTestCase {
     checkNot("-I", packageRoot.appending(components: "Sources", "libC", "include").asString, arguments: argumentsB)
   }
 
+  func testUnknownFile() {
+    // FIXME: should be possible to use InMemoryFileSystem.
+    let fs = localFileSystem
+    let tempDir = try! TemporaryDirectory(removeTreeOnDeinit: true)
+    try! fs.createFiles(root: tempDir.path, files: [
+      "pkg/Sources/libA/a.swift": "",
+      "pkg/Sources/libB/b.swift": "",
+      "pkg/Package.swift": """
+          // swift-tools-version:4.2
+          import PackageDescription
+          let package = Package(name: "a", products: [], dependencies: [],
+            targets: [
+              .target(name: "libA", dependencies: []),
+            ])
+          """
+    ])
+    let packageRoot = tempDir.path.appending(component: "pkg")
+    let tr = ToolchainRegistry.shared
+    let ws = try! SwiftPMWorkspace(
+      workspacePath: packageRoot,
+      toolchainRegistry: tr,
+      fileSystem: fs)
+
+    let aswift = packageRoot.appending(components: "Sources", "libA", "a.swift")
+    let bswift = packageRoot.appending(components: "Sources", "libB", "b.swift")
+    XCTAssertNotNil(ws.settings(for: aswift.asURL, .swift))
+    XCTAssertNil(ws.settings(for: bswift.asURL, .swift))
+    XCTAssertNil(ws.settings(for: URL(string: "https://www.apple.com")!, .swift))
+  }
+
   func testBasicCXXArgs() {
     // FIXME: should be possible to use InMemoryFileSystem.
     let fs = localFileSystem
@@ -218,28 +275,37 @@ final class SwiftPMWorkspaceTests: XCTestCase {
 
     XCTAssertEqual(ws.buildPath, build)
     XCTAssertNotNil(ws.indexStorePath)
-    let arguments = ws.settings(for: acxx.asURL, .cpp)!.compilerArguments
 
-    check("-MD", "-MT", "dependencies",
-      "-MF", build.appending(components: "lib.build", "a.cpp.d").asString,
-      arguments: arguments)
-    check("-std=c++14", arguments: arguments)
+    let checkArgsCommon = { (arguments: [String]) in
+      check("-std=c++14", arguments: arguments)
 
-    checkNot("-arch", arguments: arguments)
-    check("-target", arguments: arguments) // Only one!
-#if os(macOS)
-    check("-target", "x86_64-apple-macosx10.10", arguments: arguments)
-    check("-isysroot", arguments: arguments)
-    check("-F", arguments: arguments)
-#else
-    check("-target", "x86_64-unknown-linux", arguments: arguments)
-#endif
+      checkNot("-arch", arguments: arguments)
+      check("-target", arguments: arguments) // Only one!
+  #if os(macOS)
+      check("-target", "x86_64-apple-macosx10.10", arguments: arguments)
+      check("-isysroot", arguments: arguments)
+      check("-F", arguments: arguments)
+  #else
+      check("-target", "x86_64-unknown-linux", arguments: arguments)
+  #endif
+
+      check("-I", packageRoot.appending(components: "Sources", "lib", "include").asString, arguments: arguments)
+      checkNot("-I", build.asString, arguments: arguments)
+      checkNot(bcxx.asString, arguments: arguments)
+    }
+
+    let args = ws.settings(for: acxx.asURL, .cpp)!.compilerArguments
+    checkArgsCommon(args)
+    check("-MD", "-MT", "dependencies",
+        "-MF", build.appending(components: "lib.build", "a.cpp.d").asString,
+        arguments: args)
+    check("-c", acxx.asString, arguments: args)
+    check("-o", build.appending(components: "lib.build", "a.cpp.o").asString, arguments: args)
 
-    check("-I", packageRoot.appending(components: "Sources", "lib", "include").asString, arguments: arguments)
-    checkNot("-I", build.asString, arguments: arguments)
-    check("-c", acxx.asString, arguments: arguments)
-    checkNot(bcxx.asString, arguments: arguments)
-    check("-o", build.appending(components: "lib.build", "a.cpp.o").asString, arguments: arguments)
+    let header = packageRoot.appending(components: "Sources", "lib", "include", "a.h")
+    let headerArgs = ws.settings(for: header.asURL, .cpp)!.compilerArguments
+    checkArgsCommon(headerArgs)
+    check("-c", "-x", "c++-header", header.asString, arguments: headerArgs)
   }
 
   func testDeploymentTargetSwift() {

Tests/SKSwiftPMWorkspaceTests/XCTestManifests.swift

@@ -9,10 +9,12 @@ extension SwiftPMWorkspaceTests {
         ("testBasicCXXArgs", testBasicCXXArgs),
         ("testBasicSwiftArgs", testBasicSwiftArgs),
         ("testDeploymentTargetSwift", testDeploymentTargetSwift),
+        ("testManifestArgs", testManifestArgs),
         ("testMultiFileSwift", testMultiFileSwift),
         ("testMultiTargetSwift", testMultiTargetSwift),
         ("testNoPackage", testNoPackage),
         ("testNoToolchain", testNoToolchain),
+        ("testUnknownFile", testUnknownFile),
         ("testUnparsablePackage", testUnparsablePackage),
     ]
 }