Merge pull request swiftlang#318 from benlangmuir/log-level-literal

Fix ExpressibleByArgument conformance on LogLevel

Author: benlangmuir

Sources/LSPLogging/LogLevel.swift

@@ -46,13 +46,7 @@ extension LogLevel: CustomStringConvertible {
 }
 
 extension LogLevel {
-  enum ConversionError: Error {
-    case unknown(value: String)
-    case custom(String)
-  }
-
-
-  public init(argument: String) throws {
+  public init?(argument: String) {
     switch argument {
     case "error":
       self = .error
@@ -66,15 +60,15 @@ extension LogLevel {
 
       // Also accept a numerical log level, for parity with SOURCEKIT_LOGGING environment variable.
       guard let value = Int(argument) else {
-        throw ConversionError.unknown(value: argument)
+        return nil
       }
 
       if let level = LogLevel(rawValue: value) {
         self = level
       } else if value > LogLevel.debug.rawValue  {
         self = .debug
       } else {
-        throw ConversionError.custom("numerical log level \(value) is out of range")
+        return nil
       }
     }
   }

Sources/LSPLogging/Logging.swift

@@ -122,7 +122,7 @@ public final class Logger {
   }
 
   public func setLogLevel(_ logLevel: String) {
-    if let level = try? LogLevel(argument: logLevel) {
+    if let level = LogLevel(argument: logLevel) {
       currentLevel = level
     }
   }