Skip to content

Commit 0531ce0

Browse files
committed
fix jsonb
1 parent 02a38e8 commit 0531ce0

File tree

4 files changed

+39
-26
lines changed

4 files changed

+39
-26
lines changed

tests/test-javalin-jsonb/pom.xml

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,16 +49,22 @@
4949
<version>${project.version}</version>
5050
</dependency>
5151

52-
<dependency>
53-
<groupId>io.avaje</groupId>
54-
<artifactId>avaje-http-hibernate-validator</artifactId>
55-
<version>3.5-RC3</version>
56-
</dependency>
57-
5852
<dependency>
5953
<groupId>io.swagger.core.v3</groupId>
6054
<artifactId>swagger-annotations</artifactId>
6155
<version>${swagger.version}</version>
56+
</dependency>
57+
58+
<dependency>
59+
<groupId>io.avaje</groupId>
60+
<artifactId>avaje-validator</artifactId>
61+
<version>2.3</version>
62+
</dependency>
63+
64+
<dependency>
65+
<groupId>io.avaje</groupId>
66+
<artifactId>avaje-validator-constraints</artifactId>
67+
<version>2.3</version>
6268
</dependency>
6369

6470
<!-- java annotation processors -->
@@ -89,6 +95,13 @@
8995
<version>2.3</version>
9096
<scope>provided</scope>
9197
</dependency>
98+
99+
<dependency>
100+
<groupId>io.avaje</groupId>
101+
<artifactId>avaje-validator-generator</artifactId>
102+
<version>2.3</version>
103+
</dependency>
104+
92105

93106
<!-- test dependencies -->
94107
<dependency>

tests/test-javalin-jsonb/src/main/java/org/example/myapp/web/GetBeanForm.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,15 @@
33
import java.util.List;
44
import java.util.Set;
55

6+
import org.jetbrains.annotations.NotNull;
7+
68
import io.avaje.http.api.Header;
79
import io.avaje.http.api.Ignore;
810
import io.avaje.http.api.QueryParam;
11+
import io.avaje.http.api.Valid;
912
import io.avaje.jsonb.Json;
10-
import jakarta.validation.Valid;
11-
import jakarta.validation.constraints.Email;
12-
import jakarta.validation.constraints.NotNull;
13-
import jakarta.validation.constraints.Size;
13+
import io.avaje.validation.constraints.Email;
14+
import io.avaje.validation.constraints.Size;
1415

1516
@Json
1617
@Valid

tests/test-javalin-jsonb/src/main/java/org/example/myapp/web/HelloForm.java

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,13 @@
22

33
import java.time.LocalDate;
44

5-
import org.hibernate.validator.constraints.URL;
6-
5+
import io.avaje.http.api.Valid;
76
import io.avaje.jsonb.Json;
8-
import jakarta.validation.Valid;
9-
import jakarta.validation.constraints.Email;
10-
import jakarta.validation.constraints.Future;
11-
import jakarta.validation.constraints.NotNull;
12-
import jakarta.validation.constraints.Size;
7+
import io.avaje.validation.constraints.Email;
8+
import io.avaje.validation.constraints.Future;
9+
import io.avaje.validation.constraints.NotNull;
10+
import io.avaje.validation.constraints.Size;
11+
import io.avaje.validation.constraints.URI;
1312

1413
@Json
1514
@Valid
@@ -22,10 +21,12 @@ public class HelloForm {
2221
@Email
2322
@Size(max = 100)
2423
String email;
25-
@URL
26-
private String url;
27-
@Future
28-
public LocalDate startDate;
24+
25+
@URI
26+
private String url;
27+
28+
@Future
29+
public LocalDate startDate;
2930

3031
public HelloForm(String name, String email) {
3132
this.name = name;

tests/test-javalin-jsonb/src/test/java/org/example/myapp/HelloControllerTest.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ void hello() {
4545
@Test
4646
void hello2() {
4747

48-
TypeRef<List<HelloDto>> listDto = new TypeRef<List<HelloDto>>() { };
48+
TypeRef<List<HelloDto>> listDto = new TypeRef<>() { };
4949
final List<HelloDto> beans = given()
5050
.get(baseUrl + "/hello")
5151
.then()
@@ -64,7 +64,7 @@ void hello2() {
6464

6565
@Test
6666
void helloAsyncRequestHandling() {
67-
TypeRef<List<HelloDto>> listDto = new TypeRef<List<HelloDto>>() { };
67+
TypeRef<List<HelloDto>> listDto = new TypeRef<>() { };
6868
final List<HelloDto> beans = given()
6969
.get(baseUrl + "/hello/async")
7070
.then()
@@ -207,8 +207,6 @@ void postForm_validation_expect_badRequest() {
207207
.as(ErrorResponse.class);
208208

209209
assertNotNull(res);
210-
assertThat(res.getMessage()).contains("failed validation");
211-
assertThat(res.get("url")).isEqualTo("must be a valid URL");
212210
assertThat(res.get("name")).isEqualTo("must not be null");
213211

214212
try {
@@ -227,7 +225,7 @@ void postForm_validation_expect_badRequest() {
227225
assertEquals(422, httpResponse.statusCode());
228226

229227
final ErrorResponse errorResponse = e.bean(ErrorResponse.class);
230-
assertThat(errorResponse.get("url")).isEqualTo("must be a valid URL");
228+
assertThat(res.get("name")).isEqualTo("must not be null");
231229
assertThat(errorResponse.get("name")).isEqualTo("must not be null");
232230
}
233231
}

0 commit comments

Comments
 (0)