Skip to content

Commit 480bfb6

Browse files
committed
fix validation
1 parent e6dc1c5 commit 480bfb6

File tree

6 files changed

+32
-22
lines changed

6 files changed

+32
-22
lines changed

http-hibernate-validator/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
<dependency>
4444
<groupId>io.avaje</groupId>
4545
<artifactId>avaje-inject</artifactId>
46-
<version>10.1</version>
46+
<version>11.0</version>
4747
<scope>provided</scope>
4848
</dependency>
4949

tests/test-javalin/pom.xml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,14 @@
5656

5757
<dependency>
5858
<groupId>io.avaje</groupId>
59-
<artifactId>avaje-http-hibernate-validator</artifactId>
60-
<version>3.5-RC3</version>
59+
<artifactId>avaje-validator</artifactId>
60+
<version>2.3</version>
61+
</dependency>
62+
63+
<dependency>
64+
<groupId>io.avaje</groupId>
65+
<artifactId>avaje-validator-constraints</artifactId>
66+
<version>2.3</version>
6167
</dependency>
6268

6369
<dependency>
@@ -81,6 +87,12 @@
8187
<version>${project.version}</version>
8288
<scope>provided</scope>
8389
</dependency>
90+
91+
<dependency>
92+
<groupId>io.avaje</groupId>
93+
<artifactId>avaje-validator-generator</artifactId>
94+
<version>2.3</version>
95+
</dependency>
8496

8597

8698
<!-- test dependencies -->

tests/test-javalin/src/main/java/org/example/myapp/web/GetBeanForm.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
package org.example.myapp.web;
22

3-
import jakarta.validation.Valid;
4-
import jakarta.validation.constraints.Email;
5-
import jakarta.validation.constraints.NotNull;
6-
import jakarta.validation.constraints.Size;
3+
import io.avaje.validation.constraints.Email;
4+
import io.avaje.validation.constraints.NotNull;
5+
import io.avaje.validation.constraints.Size;
6+
import io.avaje.validation.constraints.Valid;
77

88
@Valid
99
public class GetBeanForm {

tests/test-javalin/src/main/java/org/example/myapp/web/HelloController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
import io.avaje.http.api.Post;
2222
import io.avaje.http.api.Produces;
2323
import io.avaje.http.api.QueryParam;
24+
import io.avaje.http.api.Valid;
2425
import io.javalin.http.Context;
2526
import io.swagger.v3.oas.annotations.Hidden;
2627
import jakarta.inject.Inject;
27-
import jakarta.validation.Valid;
2828

2929
/**
3030
* Hello resource manager.

tests/test-javalin/src/main/java/org/example/myapp/web/HelloForm.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,12 @@
22

33
import java.time.LocalDate;
44

5-
import org.hibernate.validator.constraints.URL;
6-
7-
import jakarta.validation.Valid;
8-
import jakarta.validation.constraints.Email;
9-
import jakarta.validation.constraints.Future;
10-
import jakarta.validation.constraints.NotNull;
11-
import jakarta.validation.constraints.Size;
5+
import io.avaje.validation.constraints.Email;
6+
import io.avaje.validation.constraints.Future;
7+
import io.avaje.validation.constraints.NotNull;
8+
import io.avaje.validation.constraints.Size;
9+
import io.avaje.validation.constraints.URI;
10+
import io.avaje.validation.constraints.Valid;
1211

1312
@Valid
1413
public class HelloForm {
@@ -19,7 +18,7 @@ public class HelloForm {
1918
@Email @Size(max = 100)
2019
String email;
2120

22-
@URL
21+
@URI
2322
String url;
2423

2524
@Future

tests/test-javalin/src/test/java/org/example/myapp/HelloControllerTest.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ void hello() {
4545
@Test
4646
void hello2() {
4747

48-
TypeRef<List<HelloDto>> listDto = new TypeRef<List<HelloDto>>() { };
48+
TypeRef<List<HelloDto>> listDto = new TypeRef<>() { };
4949
final List<HelloDto> beans = given()
5050
.get(baseUrl + "/hello")
5151
.then()
@@ -65,7 +65,7 @@ void hello2() {
6565

6666
@Test
6767
void helloAsyncRequestHandling() {
68-
TypeRef<List<HelloDto>> listDto = new TypeRef<List<HelloDto>>() { };
68+
TypeRef<List<HelloDto>> listDto = new TypeRef<>() { };
6969
final List<HelloDto> beans = given()
7070
.get(baseUrl + "/hello/async")
7171
.then()
@@ -209,9 +209,7 @@ void postForm_validation_expect_badRequest() {
209209
.as(ErrorResponse.class);
210210

211211
assertNotNull(res);
212-
assertThat(res.getMessage()).contains("failed validation");
213-
assertThat(res.get("url")).isEqualTo("must be a valid URL");
214-
assertThat(res.get("name")).isEqualTo("must not be null");
212+
assertThat(res.getMessage()).contains("must not be null");
215213

216214
try {
217215
client.request()
@@ -229,7 +227,8 @@ void postForm_validation_expect_badRequest() {
229227
assertEquals(422, httpResponse.statusCode());
230228

231229
final ErrorResponse errorResponse = e.bean(ErrorResponse.class);
232-
assertThat(errorResponse.get("url")).isEqualTo("must be a valid URL");
230+
231+
assertThat(res.getMessage()).contains("must not be null");
233232
assertThat(errorResponse.get("name")).isEqualTo("must not be null");
234233
}
235234
}

0 commit comments

Comments
 (0)