#81 - Fix Double query param should be toDouble() but is bodyAsClass()

Author: rbygrave

http-generator-core/src/main/java/io/avaje/http/generator/core/TypeMap.java

@@ -19,12 +19,14 @@ private static void add(TypeHandler h) {
   static {
     types.put("int", new IntHandler());
     types.put("long", new PLongHandler());
+    types.put("double", new PDoubleHandler());
     types.put("float", new PFloatHandler());
     types.put("boolean", new BoolHandler());
 
     types.put("java.lang.String", new StringHandler());
     types.put("java.lang.Integer", new IntegerHandler());
     types.put("java.lang.Long", new LongHandler());
+    types.put("java.lang.Double", new DoubleHandler());
     types.put("java.lang.Float", new FloatHandler());
     types.put("java.lang.Boolean", new BooleanHandler());
 
@@ -123,6 +125,28 @@ static class PFloatHandler extends Primitive {
     }
   }
 
+  static class DoubleHandler extends JavaLangType {
+    DoubleHandler() {
+      super("Double");
+    }
+
+    @Override
+    public String asMethod() {
+      return "asDouble(";
+    }
+
+    @Override
+    public String toMethod() {
+      return "toDouble(";
+    }
+  }
+
+  static class PDoubleHandler extends Primitive {
+    PDoubleHandler() {
+      super("Double");
+    }
+  }
+
   static class BooleanHandler extends JavaLangType {
     BooleanHandler() {
       super("Boolean");

http-generator-core/src/test/java/io/avaje/http/generator/core/TypeMapTest.java

@@ -0,0 +1,56 @@
+package io.avaje.http.generator.core;
+
+import org.junit.jupiter.api.Test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.*;
+
+class TypeMapTest {
+
+  @Test
+  void get_int() {
+    TypeHandler handler = TypeMap.get("int");
+    assertThat(handler.asMethod()).isEqualTo("asInt(");
+    assertTrue(handler.isPrimitive());
+  }
+
+  @Test
+  void get_Integer() {
+    TypeHandler handler = TypeMap.get("java.lang.Integer");
+    assertThat(handler).isInstanceOf(TypeMap.IntegerHandler.class);
+    assertThat(handler.asMethod()).isEqualTo("asInteger(");
+    assertFalse(handler.isPrimitive());
+  }
+
+  @Test
+  void get_double() {
+    TypeHandler handler = TypeMap.get("double");
+    assertThat(handler).isInstanceOf(TypeMap.PDoubleHandler.class);
+    assertThat(handler.asMethod()).isEqualTo("asDouble(");
+    assertTrue(handler.isPrimitive());
+  }
+
+  @Test
+  void get_Double() {
+    TypeHandler handler = TypeMap.get("java.lang.Double");
+    assertThat(handler).isInstanceOf(TypeMap.DoubleHandler.class);
+    assertThat(handler.asMethod()).isEqualTo("asDouble(");
+    assertFalse(handler.isPrimitive());
+  }
+
+  @Test
+  void get_float() {
+    TypeHandler handler = TypeMap.get("float");
+    assertThat(handler).isInstanceOf(TypeMap.PFloatHandler.class);
+    assertThat(handler.asMethod()).isEqualTo("asFloat(");
+    assertTrue(handler.isPrimitive());
+  }
+
+  @Test
+  void get_Float() {
+    TypeHandler handler = TypeMap.get("java.lang.Float");
+    assertThat(handler).isInstanceOf(TypeMap.FloatHandler.class);
+    assertThat(handler.asMethod()).isEqualTo("asFloat(");
+    assertFalse(handler.isPrimitive());
+  }
+}

tests/test-javalin/src/main/java/org/example/myapp/web/BazController.java

@@ -35,4 +35,9 @@ List<Baz> searchByName(String name) {
 
     return Arrays.asList(b1, b2);
   }
+
+  @Get("checkparams/{id}")
+  String checkParams(int id, String p1, Double p2, Integer p3, Float p4, String body) {
+    return "dummy-response";
+  }
 }