#171 - Module (custom scope) dependencies aren't fully transitive

Author: rbygrave

inject-generator/src/main/java/io/avaje/inject/generator/ScopeInfo.java

@@ -407,11 +407,18 @@ boolean providedByOtherModule(String dependency) {
     if (scopes.providedByDefaultModule(dependency)) {
       return true;
     }
+    return providesDependencyRecursive(dependency);
+  }
+
+  boolean providesDependencyRecursive(String dependency) {
+    if (providesDependency(dependency)) {
+      return true;
+    }
     // look for required scopes ...
     for (String require : requires) {
       final ScopeInfo requiredScope = scopes.get(require);
       if (requiredScope != null) {
-        if (requiredScope.providesDependency(dependency)) {
+        if (requiredScope.providesDependencyRecursive(dependency)) {
           // context.logWarn("dependency " + dependency + " provided by other scope " + requiredScope.name);
           return true;
         }

inject-test/src/test/java/org/example/custom4/Build.java

@@ -0,0 +1,4 @@
+package org.example.custom4;
+
+public class Build {
+}

inject-test/src/test/java/org/example/custom4/BuildOne.java

@@ -0,0 +1,11 @@
+package org.example.custom4;
+
+@BuildScope
+public class BuildOne {
+
+  private final Build build;
+
+  BuildOne(Build build) {
+    this.build = build;
+  }
+}

inject-test/src/test/java/org/example/custom4/BuildScope.java

@@ -0,0 +1,9 @@
+package org.example.custom4;
+
+import io.avaje.inject.InjectModule;
+import jakarta.inject.Scope;
+
+@Scope
+@InjectModule(requires = Build.class )
+public @interface BuildScope {
+}

inject-test/src/test/java/org/example/custom4/LinuxOne.java

@@ -0,0 +1,13 @@
+package org.example.custom4;
+
+@LinuxScope
+public class LinuxOne {
+
+  private final Machine machine;
+  private final Build build;
+
+  LinuxOne(Machine machine, Build build) {
+    this.machine = machine;
+    this.build = build;
+  }
+}

inject-test/src/test/java/org/example/custom4/LinuxScope.java

@@ -0,0 +1,9 @@
+package org.example.custom4;
+
+import io.avaje.inject.InjectModule;
+import jakarta.inject.Scope;
+
+@Scope
+@InjectModule(requires = {MachineScope.class})
+public @interface LinuxScope {
+}

inject-test/src/test/java/org/example/custom4/Machine.java

@@ -0,0 +1,4 @@
+package org.example.custom4;
+
+public class Machine {
+}

inject-test/src/test/java/org/example/custom4/MachineOne.java

@@ -0,0 +1,13 @@
+package org.example.custom4;
+
+@MachineScope
+public class MachineOne {
+
+  private final Build build;
+  private final Machine machine;
+
+  MachineOne(Build build, Machine machine) {
+    this.build = build;
+    this.machine = machine;
+  }
+}

inject-test/src/test/java/org/example/custom4/MachineScope.java

@@ -0,0 +1,9 @@
+package org.example.custom4;
+
+import io.avaje.inject.InjectModule;
+import jakarta.inject.Scope;
+
+@Scope
+@InjectModule(requires = {Machine.class, BuildScope.class})
+public @interface MachineScope {
+}