Simplify internals for getting list of beans

Author: rbygrave

inject/src/main/java/io/avaje/inject/spi/DBeanMap.java

@@ -61,14 +61,12 @@ <T> BeanEntry<T> candidate(Class<T> type, String name) {
   }
 
   /**
-   * Add all bean instances matching the given type to the list.
+   * Return all bean instances matching the given type.
    */
-  @SuppressWarnings({"unchecked", "rawtypes"})
-  void addAll(Class type, List list) {
+  @SuppressWarnings("rawtypes")
+  List<Object> all(Class type) {
     DContextEntry entry = beans.get(type.getCanonicalName());
-    if (entry != null) {
-      entry.addAll(list);
-    }
+    return entry != null ? entry.all() : Collections.emptyList();
   }
 
   /**

inject/src/main/java/io/avaje/inject/spi/DBeanScope.java

@@ -54,9 +54,7 @@ public <T> T get(Class<T> beanClass, String name) {
 
   @Override
   public <T> List<T> list(Class<T> interfaceType) {
-    List<T> list = new ArrayList<>();
-    beans.addAll(interfaceType, list);
-    return list;
+    return (List<T>)beans.all(interfaceType);
   }
 
   @Override
@@ -101,9 +99,7 @@ public <T> List<T> sortByPriority(List<T> list, final Class<? extends Annotation
 
   @Override
   public List<Object> getBeansWithAnnotation(Class<?> annotation) {
-    List<Object> list = new ArrayList<>();
-    beans.addAll(annotation, list);
-    return list;
+    return beans.all(annotation);
   }
 
   @Override

inject/src/main/java/io/avaje/inject/spi/DBuilder.java

@@ -79,12 +79,10 @@ public <T> Set<T> getSet(Class<T> interfaceType) {
     return new LinkedHashSet<>(getList(interfaceType));
   }
 
-  @SuppressWarnings({"unchecked", "rawtypes"})
+  @SuppressWarnings({"unchecked"})
   @Override
   public <T> List<T> getList(Class<T> interfaceType) {
-    List list = new ArrayList<>();
-    beanMap.addAll(interfaceType, list);
-    return (List<T>) list;
+    return (List<T>) beanMap.all(interfaceType);
   }
 
   private <T> T getMaybe(Class<T> beanClass, String name) {

inject/src/main/java/io/avaje/inject/spi/DContextEntry.java

@@ -30,12 +30,14 @@ <T> BeanEntry<T> candidate(String name) {
   }
 
   /**
-   * Add all the managed beans to the given list.
+   * Return all the beans.
    */
-  void addAll(List<Object> appendToList) {
+  List<Object> all() {
+    List<Object> list = new ArrayList<>(entries.size());
     for (DContextEntryBean entry : entries) {
-      appendToList.add(entry.getBean());
+      list.add(entry.getBean());
     }
+    return list;
   }
 
   void add(DContextEntryBean entryBean) {