Skip to content

Commit 27e5212

Browse files
committed
#100 - Tidy internal register methods
1 parent 321eb21 commit 27e5212

File tree

2 files changed

+8
-26
lines changed

2 files changed

+8
-26
lines changed

inject/src/main/java/io/avaje/inject/spi/DBeanMap.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,7 @@ private void addSuppliedBean(SuppliedBean supplied) {
4242
}
4343
}
4444

45-
void registerPrimary(Object bean) {
46-
registerWith(PRIMARY, bean);
47-
}
48-
49-
void registerSecondary(Object bean) {
50-
registerWith(SECONDARY, bean);
51-
}
52-
53-
void register(Object bean) {
54-
registerWith(NORMAL, bean);
55-
}
56-
57-
void registerWith(int flag, Object bean) {
45+
void register(int flag, Object bean) {
5846
DContextEntryBean entryBean = DContextEntryBean.of(bean, nextBean.name, flag);
5947
for (Class<?> type : nextBean.types) {
6048
beans.computeIfAbsent(type.getCanonicalName(), s -> new DContextEntry()).add(entryBean);

inject/src/main/java/io/avaje/inject/spi/DBuilder.java

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -175,31 +175,25 @@ public <T> T enrich(T bean, Class<?>[] types) {
175175

176176
@Override
177177
public <T> T register(T bean) {
178-
if (parent != null) {
179-
// enrichment only exist on top level builder
180-
bean = parent.enrich(bean, beanMap.types());
181-
}
182-
beanMap.register(bean);
183-
return bean;
178+
return register(BeanEntry.NORMAL, bean);
184179
}
185180

186181
@Override
187182
public <T> T registerPrimary(T bean) {
188-
if (parent != null) {
189-
// enrichment only exist on top level builder
190-
bean = parent.enrich(bean, beanMap.types());
191-
}
192-
beanMap.registerPrimary(bean);
193-
return bean;
183+
return register(BeanEntry.PRIMARY, bean);
194184
}
195185

196186
@Override
197187
public <T> T registerSecondary(T bean) {
188+
return register(BeanEntry.SECONDARY, bean);
189+
}
190+
191+
private <T> T register(int flag, T bean) {
198192
if (parent != null) {
199193
// enrichment only exist on top level builder
200194
bean = parent.enrich(bean, beanMap.types());
201195
}
202-
beanMap.registerSecondary(bean);
196+
beanMap.register(flag, bean);
203197
return bean;
204198
}
205199

0 commit comments

Comments
 (0)