#145 - Missing full qualifier on private fields in module classes

Author: rbygrave

inject-generator/src/main/java/io/avaje/inject/generator/ScopeInfo.java

@@ -401,18 +401,23 @@ boolean providesDependency(String dependency) {
     return false;
   }
 
-  boolean addModuleConstructor() {
+  Set<String> initModuleDependencies(Set<String> importTypes) {
     if (defaultScope || requires.isEmpty()) {
-      return false;
+      return importTypes;
     }
     for (String require : requires) {
       final ScopeInfo otherScope = scopes.get(require);
       if (otherScope == null) {
+        importTypes.add(require);
         final String type = Util.shortName(require);
         final String var = Util.initLower(type);
         constructorDependencies.put(type, var);
       }
     }
+    return importTypes;
+  }
+
+  boolean addModuleConstructor() {
     return !constructorDependencies.isEmpty();
   }
 

inject-generator/src/main/java/io/avaje/inject/generator/SimpleModuleWriter.java

@@ -114,7 +114,7 @@ private void writePackage() {
     for (String type : factoryImportTypes()) {
       writer.append("import %s;", type).eol();
     }
-    for (String type : ordering.getImportTypes()) {
+    for (String type : scopeInfo.initModuleDependencies(ordering.getImportTypes())) {
       if (Util.validImportType(type)) {
         writer.append("import %s;", type).eol();
       }
@@ -156,14 +156,14 @@ private void writeStartClass() {
 
   private void writeWithBeans() {
     writer.append("    // register external dependencies").eol();
-    final Map<String,String> dependencies = scopeInfo.constructorDependencies();
+    final Map<String, String> dependencies = scopeInfo.constructorDependencies();
     for (Map.Entry<String, String> entry : dependencies.entrySet()) {
       writer.append("    builder.withBean(%s.class, %s);", entry.getKey(), entry.getValue()).eol();
     }
   }
 
   private void writeConstructor() {
-    final Map<String,String> dependencies = scopeInfo.constructorDependencies();
+    final Map<String, String> dependencies = scopeInfo.constructorDependencies();
     for (Map.Entry<String, String> entry : dependencies.entrySet()) {
       writer.append("  private %s %s;", entry.getKey(), entry.getValue()).eol();
     }

inject-test/src/test/java/org/example/MyCustomScope.java

@@ -2,7 +2,7 @@
 
 import io.avaje.inject.InjectModule;
 import jakarta.inject.Scope;
-import org.example.custom.LocalExternal;
+import org.example.custom.loc.LocalExternal;
 
 @Scope
 @InjectModule(requires = {LocalExternal.class})

inject-test/src/test/java/org/example/custom/CustomScopeTest.java

@@ -4,6 +4,7 @@
 import io.avaje.inject.BeanScope;
 import org.example.MyCustomScope;
 import org.example.coffee.CoffeeMaker;
+import org.example.custom.loc.LocalExternal;
 import org.junit.jupiter.api.Test;
 import org.mockito.Mockito;
 

inject-test/src/test/java/org/example/custom/FooCustom.java

@@ -2,6 +2,7 @@
 
 import org.example.MyCustomScope;
 import org.example.coffee.CoffeeMaker;
+import org.example.custom.loc.LocalExternal;
 
 @MyCustomScope
 public class FooCustom {

inject-test/src/test/java/org/example/custom/LocalExternal.java renamed to inject-test/src/test/java/org/example/custom/loc/LocalExternal.java

@@ -1,4 +1,4 @@
-package org.example.custom;
+package org.example.custom.loc;
 
 public interface LocalExternal {
 }