#144 - Implied qualifier name for constructor parameters takes [suffix] type name into account

Author: rbygrave

inject-generator/src/main/java/io/avaje/inject/generator/MethodReader.java

@@ -266,7 +266,14 @@ String builderGetDependency(String builderName) {
         sb.append(",\"").append(named).append("\"");
       } else if (!isGenericParam() && utilType.allowsNamedQualifier()) {
         // implied qualifier name, leading '!' means implied
-        sb.append(",\"!").append(simpleName).append("\"");
+        sb.append(",\"!");
+        final String shortName = Util.shortName(paramType);
+        if (simpleName.endsWith(shortName)) {
+          sb.append(simpleName, 0, simpleName.length() - shortName.length());
+        } else {
+          sb.append(simpleName);
+        }
+        sb.append("\"");
       }
       sb.append(")");
       return sb.toString();

inject-test/src/test/java/org/example/coffee/primary/UseNamedPEmailer.java

@@ -0,0 +1,31 @@
+package org.example.coffee.primary;
+
+import jakarta.inject.Named;
+import jakarta.inject.Singleton;
+
+@Singleton
+public class UseNamedPEmailer {
+
+  private final PEmailer emailer;
+  private final PEmailer other;
+  private final PEmailer otherPEmailer;
+
+  public UseNamedPEmailer(@Named("Other") PEmailer emailer, PEmailer other, PEmailer otherPEmailer) {
+    this.emailer = emailer;
+    this.other = other;
+    this.otherPEmailer = otherPEmailer;
+  }
+
+  public String emailNamed() {
+    return emailer.email();
+  }
+
+  public String emailOther() {
+    return other.email();
+  }
+
+  public String emailOtherPEmailer() {
+    return otherPEmailer.email();
+  }
+
+}

inject-test/src/test/java/org/example/coffee/primary/UseNamedPEmailerTest.java

@@ -0,0 +1,17 @@
+package org.example.coffee.primary;
+
+import io.avaje.inject.ApplicationScope;
+import org.junit.jupiter.api.Test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class UseNamedPEmailerTest {
+
+  @Test
+  void named_secondary() {
+    UseNamedPEmailer bean = ApplicationScope.get(UseNamedPEmailer.class);
+    assertThat(bean.emailNamed()).isEqualTo("other");
+    assertThat(bean.emailOther()).isEqualTo("other");
+    assertThat(bean.emailOtherPEmailer()).isEqualTo("other");
+  }
+}