Deprecate the use of @Aspect.target with the view to remove it

Author: rbygrave

blackbox-aspect/src/main/java/org/example/external/aspect/MyExternalAspect.java

@@ -1,14 +1,13 @@
 package org.example.external.aspect;
 
 import io.avaje.inject.aop.Aspect;
-import org.example.external.aspect.sub.MyAspectImplementation;
 
 import java.lang.annotation.ElementType;
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
-@Aspect(target = MyAspectImplementation.class)
+@Aspect
 @Target(ElementType.METHOD)
 @Retention(RetentionPolicy.RUNTIME)
 public @interface MyExternalAspect {

blackbox-aspect/src/main/java/org/example/external/aspect/sub/MyAspectImplementation.java

@@ -10,7 +10,7 @@
 import java.util.Arrays;
 
 @Component
-public class MyAspectImplementation implements AspectProvider<MyExternalAspect>, MethodInterceptor {
+class MyAspectImplementation implements AspectProvider<MyExternalAspect>, MethodInterceptor {
 
   @Override
   public MethodInterceptor interceptor(Method method, MyExternalAspect aspectAnnotation) {

blackbox-test-inject/src/main/java/org/example/myapp/aspect/MyAround.java

@@ -7,7 +7,7 @@
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
-@Aspect(target = MyAroundAspect.class)
+@Aspect
 @Target(ElementType.METHOD)
 @Retention(RetentionPolicy.RUNTIME)
 public @interface MyAround {

blackbox-test-inject/src/main/java/org/example/myapp/aspect/MyAroundAspect.java

@@ -11,7 +11,6 @@
 import java.util.List;
 
 @Singleton
-//@Aspect(target = MyAround.class)
 public class MyAroundAspect implements AspectProvider<MyAround>, MethodInterceptor {
 
   private final List<String> trace = new ArrayList<>();

inject-generator/src/main/java/io/avaje/inject/generator/AspectAnnotationReader.java

@@ -44,9 +44,7 @@ private Meta readTarget(Element anElement) {
         Meta meta = new Meta();
         for (Map.Entry<? extends ExecutableElement, ? extends AnnotationValue> entry : annotationMirror.getElementValues().entrySet()) {
           String key = entry.getKey().toString();
-          if (key.equals("target()")) {
-            meta.target(entry.getValue().getValue().toString());
-          } else if (key.equals("ordering()")) {
+          if (key.equals("ordering()")) {
             meta.ordering(Integer.parseInt(entry.getValue().getValue().toString()));
           }
         }
@@ -59,21 +57,15 @@ private Meta readTarget(Element anElement) {
 
   private static class Meta {
 
-    String target;
-
     int ordering = Constants.ORDERING_DEFAULT;
 
-    void target(String target) {
-      this.target = target;
-    }
-
     void ordering(int ordering) {
       this.ordering = ordering;
     }
 
     @Override
     public String toString() {
-      return "Meta(target=" + target + ", ordering=" + ordering + ')';
+      return "Meta(ordering=" + ordering + ')';
     }
   }
 }

inject/src/main/java/io/avaje/inject/aop/Aspect.java

@@ -18,9 +18,10 @@
 public @interface Aspect {
 
   /**
-   * Specify the {@link AspectProvider} for this aspect.
+   * Deprecated - the target() attribute is no longer required and should be removed.
    */
-  Class<? extends AspectProvider> target();
+  @Deprecated
+  Class<?> target() default Void.class;
 
   /**
    * Specify the priority ordering when multiple aspects are on a method.