Skip to content

Commit b3988ed

Browse files
committed
#103 - Handle @nAmed with empty string / no actual string qualifier name
1 parent c937a61 commit b3988ed

File tree

4 files changed

+29
-2
lines changed

4 files changed

+29
-2
lines changed

inject-generator/src/main/java/io/avaje/inject/generator/BeanReader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ boolean isExtraInjectionRequired() {
283283

284284
void buildAddFor(Append writer) {
285285
writer.append(" if (builder.isAddBeanFor(");
286-
if (name != null) {
286+
if (name != null && !name.isEmpty()) {
287287
writer.append("\"%s\", ", name);
288288
}
289289
writer.append(typeReader.getTypesRegister());

inject-generator/src/main/java/io/avaje/inject/generator/MethodReader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ void buildAddFor(Append writer) {
176176
if (isVoid) {
177177
writer.append("Void.class");
178178
} else {
179-
if (name != null) {
179+
if (name != null && !name.isEmpty()) {
180180
writer.append("\"%s\", ", name);
181181
}
182182
if (typeReader != null) {
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
package org.example.coffee.qualifier;
2+
3+
import jakarta.inject.Named;
4+
import jakarta.inject.Singleton;
5+
6+
/**
7+
* Named with empty string.
8+
*/
9+
@Named
10+
@Singleton
11+
public class FooQual {
12+
}
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
package org.example.coffee.qualifier;
2+
3+
import io.avaje.inject.SystemContext;
4+
import org.junit.jupiter.api.Test;
5+
6+
import static org.assertj.core.api.Assertions.assertThat;
7+
8+
class FooQualTest {
9+
10+
@Test
11+
void test() {
12+
FooQual bean = SystemContext.getBean(FooQual.class);
13+
assertThat(bean).isNotNull();
14+
}
15+
}

0 commit comments

Comments
 (0)