#439 Handle case where method injection throws exception

Adds a try catch block to the generated code

Author: rbygrave

inject-generator/src/main/java/io/avaje/inject/generator/BeanReader.java

@@ -448,4 +448,13 @@ private String beanPackageName() {
   private String beanQualifiedName() {
     return beanType.getQualifiedName().toString();
   }
+
+  boolean needsTryForMethodInjection() {
+    for (MethodReader injectMethod : injectMethods) {
+      if (injectMethod.methodThrows()) {
+        return true;
+      }
+    }
+    return false;
+  }
 }

inject-generator/src/main/java/io/avaje/inject/generator/MethodReader.java

@@ -281,7 +281,7 @@ void buildAddFor(Append writer) {
     writer.append(")) {").eol();
   }
 
-  private boolean methodThrows() {
+  boolean methodThrows() {
     return !element.getThrownTypes().isEmpty();
   }
 

inject-generator/src/main/java/io/avaje/inject/generator/SimpleBeanWriter.java

@@ -226,12 +226,22 @@ private void injectFields() {
   }
 
   private void injectMethods() {
-    String bean = beanReader.prototype() ? "bean" : "$bean";
-    String builder = beanReader.prototype() ? "builder" : "b";
+    final var needsTry = beanReader.needsTryForMethodInjection();
+    final var bean = beanReader.prototype() ? "bean" : "$bean";
+    final var builder = beanReader.prototype() ? "builder" : "b";
+    if (needsTry) {
+      writer.indent("        try {").eol();
+    }
+    final var indent = needsTry ? "          " : "        ";
     for (MethodReader methodReader : beanReader.injectMethods()) {
-      writer.indent("        ").append("%s.%s(", bean, methodReader.name());
+      writer.indent(indent).append("%s.%s(", bean, methodReader.name());
       writeMethodParams(builder, methodReader);
     }
+    if (needsTry) {
+      writer.indent("        } catch (Throwable e) {").eol();
+      writer.indent("          throw new RuntimeException(\"Error wiring method\", e);").eol();
+      writer.indent("        }").eol();
+    }
   }
 
   private void writeMethodParams(String builderRef, MethodReader methodReader) {

inject-test/src/test/java/org/example/coffee/fruit/AppleService.java

@@ -3,6 +3,8 @@
 import jakarta.inject.Inject;
 import jakarta.inject.Singleton;
 
+import java.io.IOException;
+
 @Singleton
 public class AppleService {
 
@@ -11,8 +13,13 @@ public class AppleService {
 
   PeachService peachService;
 
+  public AppleService() throws IOException {
+    // maybe I throw on construction
+  }
+
   @Inject
-  void setPeachService(PeachService peachService) {
+  void setPeachService(PeachService peachService) throws IOException {
+    // maybe I throw on method injection
     this.peachService = peachService;
   }