Skip to content

Commit e08e45e

Browse files
committed
no longer strip @ from qualifiers
1 parent 90e34a9 commit e08e45e

File tree

15 files changed

+27
-27
lines changed

15 files changed

+27
-27
lines changed

inject-generator/src/main/java/io/avaje/inject/generator/AnnotationCopier.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public static void copyAnnotations(
3838
}
3939

4040
static String getSimpleAnnotationString(AnnotationMirror annotationMirror) {
41-
return Util.trimAnnotationString(getAnnotationString("", annotationMirror, true)).substring(1);
41+
return Util.trimAnnotationString(getAnnotationString("", annotationMirror, true));
4242
}
4343

4444
static String getAnnotationString(

inject-test/src/main/java/io/avaje/inject/test/MetaReader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ private String name(Field field) {
124124
if (metaAnnotation.annotationType().equals(Qualifier.class)) {
125125
return AnnotationReader.simplifyAnnotation(annotation.toString())
126126
.replaceFirst(annotationType.getCanonicalName(), annotationType.getSimpleName())
127-
.replace("()", "").substring(1)
127+
.replace("()", "")
128128
.toLowerCase();
129129
}
130130
}

inject-test/src/test/java/org/example/coffee/INeedBeanScope.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ class INeedBeanScope {
1717
}
1818

1919
Que getQueue() {
20-
return beanScope.get(Que.class, "frodo");
20+
return beanScope.get(Que.class, "@frodo");
2121
}
2222
}

inject-test/src/test/java/org/example/coffee/qualifier/StoreManagerWithNamed.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ public class StoreManagerWithNamed {
88

99
private final SomeStore store;
1010

11-
public StoreManagerWithNamed(@Named("Blue") SomeStore store) {
11+
public StoreManagerWithNamed(@Named("@Blue") SomeStore store) {
1212
this.store = store;
1313
}
1414

inject-test/src/test/java/org/example/coffee/qualifier/StoreManagerWithNamedTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ void test() {
1717
String store = manager.store();
1818
assertThat(store).isEqualTo("blue");
1919

20-
SomeStore greenStore = beanScope.get(SomeStore.class, "green");
21-
SomeStore blueStore = beanScope.get(SomeStore.class, "blue");
20+
SomeStore greenStore = beanScope.get(SomeStore.class, "@green");
21+
SomeStore blueStore = beanScope.get(SomeStore.class, "@blue");
2222
Map<String, SomeStore> stores = beanScope.map(SomeStore.class);
2323

24-
SomeStore green = stores.get("green");
24+
SomeStore green = stores.get("@green");
2525
assertThat(green).isSameAs(greenStore);
26-
SomeStore blue = stores.get("blue");
26+
SomeStore blue = stores.get("@blue");
2727
assertThat(blue).isSameAs(blueStore);
2828

2929
// a map with unnamed component

inject-test/src/test/java/org/example/coffee/qualifier/StoreManagerWithSetterQualifierTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ void redStore() {
1919
@Test
2020
void namedTestDouble() {
2121
try (BeanScope context = BeanScope.builder()
22-
.bean("Blue", SomeStore.class, () -> "TD Blue")
23-
.bean("Green", SomeStore.class, () -> "TD Green")
22+
.bean("@Blue", SomeStore.class, () -> "TD Blue")
23+
.bean("@Green", SomeStore.class, () -> "TD Green")
2424
.build()) {
2525

2626
StoreManagerWithSetterQualifier manager = context.get(StoreManagerWithSetterQualifier.class);
@@ -32,7 +32,7 @@ void namedTestDouble() {
3232
@Test
3333
void namedTestDouble_expect_otherNamedStillWired() {
3434
try (BeanScope context = BeanScope.builder()
35-
.bean("Blue", SomeStore.class, () -> "TD Blue Only")
35+
.bean("@Blue", SomeStore.class, () -> "TD Blue Only")
3636
// with GreenStore still wired
3737
.build()) {
3838

inject-test/src/test/java/org/example/coffee/qualifier/members/SpyMeterTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
class SpyMeterTest {
1616

1717
private static final String METRIC =
18-
"TempQualifier(defaultVal=0, inject={@NestedAnnotation(inject={})}, someOtherString=\"celsi\", value={CELSIUS})";
18+
"@TempQualifier(defaultVal=0, inject={@NestedAnnotation(inject={})}, someOtherString=\"celsi\", value={CELSIUS})";
1919
private static final String IMPERIAL =
20-
"TempQualifier(defaultVal=0, inject={@NestedAnnotation(inject={})}, someOtherString=\"far\", value={FAHRENHEIT})";
20+
"@TempQualifier(defaultVal=0, inject={@NestedAnnotation(inject={})}, someOtherString=\"far\", value={FAHRENHEIT})";
2121

2222
@Spy
2323
@TempQualifier(value = Scale.FAHRENHEIT, someOtherString = "far")

inject-test/src/test/java/org/example/injectextension/WithExtnNamedMocksTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class WithExtnNamedMocksTest {
1919

2020
@Mock @Blue SomeStore blueStore;
2121

22-
@Mock @Named("green") SomeStore greenStore;
22+
@Mock @Named("@green") SomeStore greenStore;
2323

2424
@Inject StoreManagerWithSetterQualifier storeManager;
2525

@@ -39,12 +39,12 @@ void test() {
3939

4040
try (BeanScope beanScope = BeanScope.builder()
4141
.forTesting()
42-
.mock(SomeStore.class, "Blue")
43-
.mock(SomeStore.class, "green")
42+
.mock(SomeStore.class, "@Blue")
43+
.mock(SomeStore.class, "@green")
4444
.build()) {
4545

46-
final SomeStore greenStore = beanScope.get(SomeStore.class, "green");
47-
final SomeStore blueStore = beanScope.get(SomeStore.class, "blue");
46+
final SomeStore greenStore = beanScope.get(SomeStore.class, "@green");
47+
final SomeStore blueStore = beanScope.get(SomeStore.class, "@blue");
4848
when(blueStore.store()).thenReturn("BlueStoreStub");
4949
when(greenStore.store()).thenReturn("GreenStoreStub");
5050

inject-test/src/test/java/org/example/injectextension/WithExtnNamedSpyTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class WithExtnNamedSpyTest {
2020
@Spy @Blue
2121
SomeStore blueStore;
2222

23-
@Spy @Named("green")
23+
@Spy @Named("@green")
2424
SomeStore greenStore;
2525

2626
@Inject
@@ -43,8 +43,8 @@ void test() {
4343

4444
try (BeanScope beanScope = BeanScope.builder()
4545
.forTesting()
46-
.spy(SomeStore.class, "blue")
47-
.spy(SomeStore.class, "Green")
46+
.spy(SomeStore.class, "@blue")
47+
.spy(SomeStore.class, "@Green")
4848
.build()) {
4949

5050
final StoreManagerWithSetterQualifier storeManager = beanScope.get(StoreManagerWithSetterQualifier.class);

inject-test/src/test/java/org/example/optional/AllQue.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class AllQue {
1515
private final Optional<Que> sam;
1616
private final Optional<Que> bilbo;
1717

18-
AllQue(@Named("frodo") Optional<Que> frodo, @Named("sam") Optional<Que> sam, @Named("bilbo") Optional<Que> bilbo) {
18+
AllQue(@Named("@Frodo") Optional<Que> frodo, @Named("sam") Optional<Que> sam, @Named("bilbo") Optional<Que> bilbo) {
1919
this.frodo = frodo;
2020
this.sam = sam;
2121
this.bilbo = bilbo;

inject-test/src/test/java/org/example/optional/AllQue2.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
@Singleton
1313
public class AllQue2 {
1414

15-
@Inject @Named("frodo") Que frodo;
15+
@Inject @Named("@Frodo") Que frodo;
1616
@Inject @Named("sam") Optional<Que> sam;
1717
@Inject @Named("bilbo") Optional<Que> bilbo;
1818

inject-test/src/test/java/org/example/optional/AllQue3.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public class AllQue3 {
1616
private Que sam;
1717
private Que bilbo;
1818

19-
AllQue3(@Named("frodo") Que frodo) {
19+
AllQue3(@Named("@Frodo") Que frodo) {
2020
this.frodo = frodo;
2121
}
2222

inject-test/src/test/java/org/example/optional/AllQue4.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public class AllQue4 {
1616
private Que sam;
1717
private Que bilbo;
1818

19-
AllQue4(@Named("frodo") Que frodo) {
19+
AllQue4(@Named("@Frodo") Que frodo) {
2020
this.frodo = frodo;
2121
}
2222

inject-test/src/test/java/org/example/optional/AllQue5.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public class AllQue5 {
1717
/**
1818
* Use Nullable with constructor argument.
1919
*/
20-
AllQue5(@Named("frodo") Que frodo, @Named("sam") Que sam, @Nullable @Named("bilbo") Que bilbo) {
20+
AllQue5(@Named("@Frodo") Que frodo, @Named("sam") Que sam, @Nullable @Named("bilbo") Que bilbo) {
2121
this.frodo = frodo;
2222
this.sam = sam;
2323
this.bilbo = bilbo;

inject-test/src/test/java/org/example/optional/AllQue6.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public class AllQue6 {
1616
@Inject @Named("sam") Que sam;
1717
@Inject @Nullable @Named("bilbo") Que bilbo;
1818

19-
AllQue6(@Named("frodo") Que frodo) {
19+
AllQue6(@Named("@Frodo") Que frodo) {
2020
this.frodo = frodo;
2121
}
2222

0 commit comments

Comments
 (0)