Revert "message cache"

This reverts commit 7ed7d55.

Author: SentryMan

validator/src/main/java/io/avaje/validation/core/CoreAdapterBuilder.java

@@ -14,11 +14,12 @@
 
 /** Builds and caches the ValidationAdapter adapters for DValidator. */
 final class CoreAdapterBuilder {
-  public static final ValidationAdapter NOOP = (type, req, propertyName) -> true;
+
   private final DValidator context;
   private final List<ValidationContext.AdapterFactory> factories = new ArrayList<>();
   private final List<ValidationContext.AnnotationFactory> annotationFactories = new ArrayList<>();
   private final Map<Object, ValidationAdapter<?>> adapterCache = new ConcurrentHashMap<>();
+  private final MessageInterpolator interpolator;
 
   CoreAdapterBuilder(
       DValidator context,
@@ -29,6 +30,7 @@ final class CoreAdapterBuilder {
     this.annotationFactories.addAll(userAnnotationFactories);
     this.annotationFactories.add(BasicAdapters.FACTORY);
     this.annotationFactories.add(NumberAdapters.FACTORY);
+    interpolator = context.interpolator();
   }
 
   /** Return the adapter from cache if exists else return null. */
@@ -74,6 +76,6 @@ <T> ValidationAdapter<T> buildAnnotation(Class<? extends Annotation> cls, Map<St
       }
     }
     // unknown annotations have noop
-    return NOOP;
+    return NoopAnnotationValidator.INSTANCE;
   }
 }

validator/src/main/java/io/avaje/validation/core/DValidator.java

@@ -9,7 +9,6 @@
 import java.lang.reflect.Type;
 import java.util.ArrayList;
 import java.util.Collections;
-import java.util.HashMap;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
@@ -32,8 +31,6 @@ final class DValidator implements Validator, ValidationContext {
   private final MessageInterpolator interpolator;
   private final LocaleResolver localeResolver;
   private final DTemplateLookup templateLookup;
-  private final Map<String, String> messageCache = new HashMap<>();
-
 
   DValidator(
       List<AdapterFactory> factories,
@@ -121,16 +118,12 @@ ValidationRequest request(@Nullable Locale locale) {
 
   String interpolate(Message msg, Locale requestLocale) {
 
-    return messageCache.computeIfAbsent(
-        requestLocale.toString() + msg.template(),
-        k -> {
-          // resolve the locale to use to produce the message
-          final Locale locale = localeResolver.resolve(requestLocale);
-          // lookup in resource bundles using resolved locale and template
-          final String template = templateLookup.lookup(msg.template(), locale);
+    // resolve the locale to use to produce the message
+    final Locale locale = localeResolver.resolve(requestLocale);
+    // lookup in resource bundles using resolved locale and template
+    final String template = templateLookup.lookup(msg.template(), locale);
 
-          return interpolator.interpolate(template, msg.attributes());
-        });
+    return interpolator.interpolate(template, msg.attributes());
   }
 
   /** Implementation of Validator.Builder. */

validator/src/main/java/io/avaje/validation/core/NoopAnnotationValidator.java

@@ -0,0 +1,16 @@
+package io.avaje.validation.core;
+
+import io.avaje.validation.adapter.ValidationAdapter;
+import io.avaje.validation.adapter.ValidationRequest;
+
+final class NoopAnnotationValidator<T> implements ValidationAdapter<T> {
+  public static final NoopAnnotationValidator INSTANCE = new NoopAnnotationValidator<>();
+
+  private NoopAnnotationValidator() {}
+
+  @Override
+  public boolean validate(T type, ValidationRequest req, String propertyName) {
+    // NOOP
+    return true;
+  }
+}