Skip to content

Start Generation #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 4, 2023
Merged

Start Generation #21

merged 13 commits into from
May 4, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented May 3, 2023 •
edited
Loading

Changes:

  • make validateAll methods private (to make generation logic easier)
  • add new list and array methods to ValidationAdapter
  • Creates Generator
  • We can actually validate the results of a no-arg method

@SentryMan SentryMan marked this pull request as ready for review May 4, 2023 01:35
@SentryMan
Copy link
Collaborator Author

SentryMan commented May 4, 2023 •
edited
Loading

@rbygrave
I'm good with this to start off with.

@rob-bygrave rob-bygrave merged commit 6281785 into avaje:main May 4, 2023
@SentryMan SentryMan deleted the generator-rex branch May 4, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SentryMan @rob-bygrave