Skip to content

Commit 5768eae

Browse files
committed
changes base on review, mainly:
* no lock * default arguments allowed
1 parent 3518d7e commit 5768eae

File tree

14 files changed

+11
-206
lines changed

14 files changed

+11
-206
lines changed

.scalafix.conf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
rules = [
2+
NoAutoTupling
23
RemoveUnused
4+
LeakingImplicitClassVal
5+
NoValInForComprehension
6+
ProcedureSyntax
7+
DisableSyntax
38
ExplicitResultTypes
49
Disable
510
]

example/lock.sbt

Lines changed: 0 additions & 113 deletions
This file was deleted.

jvm-execution/lock.sbt

Lines changed: 0 additions & 18 deletions
This file was deleted.

jvm-execution/src/main/scala/com/avast/server/toolkit/execution/ConfigurableThreadFactory.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ object ConfigurableThreadFactory {
3535
/**
3636
* @param nameFormat Formatted with long number, e.g. my-thread-%02d
3737
*/
38-
@SuppressWarnings(Array("org.wartremover.warts.DefaultArguments"))
3938
final case class Config(nameFormat: Option[String] = None,
4039
daemon: Boolean = false,
4140
priority: Int = Thread.NORM_PRIORITY,

jvm-execution/src/main/scala/com/avast/server/toolkit/execution/ForkJoinPoolConfig.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package com.avast.server.toolkit.execution
33
import ForkJoinPoolConfig.TaskPeekingMode
44
import ForkJoinPoolConfig.TaskPeekingMode.{FIFO, LIFO}
55

6-
@SuppressWarnings(Array("org.wartremover.warts.DefaultArguments"))
76
final case class ForkJoinPoolConfig(parallelismMin: Int = 8,
87
parallelismFactor: Double = 1.0,
98
parallelismMax: Int = 64,

jvm-execution/src/main/scala/com/avast/server/toolkit/execution/ThreadPoolExecutorConfig.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import java.util.concurrent.TimeUnit
44

55
import scala.concurrent.duration.{Duration, FiniteDuration}
66

7-
@SuppressWarnings(Array("org.wartremover.warts.DefaultArguments"))
87
final case class ThreadPoolExecutorConfig(coreSize: Int,
98
maxSize: Int,
109
keepAlive: FiniteDuration = Duration(1000L, TimeUnit.MILLISECONDS),

jvm-ssl/lock.sbt

Lines changed: 0 additions & 17 deletions
This file was deleted.

jvm-ssl/src/main/scala/com/avast/server/toolkit/ssl/SslContextConfig.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package com.avast.server.toolkit.ssl
33
import com.avast.server.toolkit.ssl.Protocol.TLS
44
import com.avast.server.toolkit.ssl.Protocol.TLS
55

6-
@SuppressWarnings(Array("org.wartremover.warts.DefaultArguments"))
76
final case class SslContextConfig(protocol: Protocol = TLS,
87
keystore: Option[KeyStoreConfig] = None,
98
truststore: Option[KeyStoreConfig] = None,

jvm-system/lock.sbt

Lines changed: 0 additions & 17 deletions
This file was deleted.

lock.sbt

Lines changed: 0 additions & 12 deletions
This file was deleted.

project/BuildHelper.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ object BuildHelper {
1818
Wart.Equals, // keep, easier that way
1919
Wart.ToString, // keep, easier that way
2020
Wart.Product, // keep, false positives all around
21-
Wart.Serializable // keep, false positives all around
21+
Wart.Serializable, // keep, false positives all around
22+
Wart.DefaultArguments // for constructors for PureConfig
2223
),
2324
ThisBuild / scalafixDependencies ++= Seq(
2425
Dependencies.scalazzi // https://github.com/scalaz/scalazzi

project/Dependencies.scala

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,16 @@ object Dependencies {
1010
val logbackClassic = "ch.qos.logback" % "logback-classic" % "1.2.3"
1111
val pureConfig = "com.github.pureconfig" %% "pureconfig" % "0.12.1"
1212
val scalaTest = "org.scalatest" %% "scalatest" % "3.0.8"
13+
val scalazzi = "com.github.vovapolu" %% "scaluzzi" % "0.1.3"
14+
val silencer = "com.github.ghik" % "silencer-plugin" % Versions.silencer cross CrossVersion.full
15+
val silencerLib = "com.github.ghik" % "silencer-lib" % Versions.silencer cross CrossVersion.full
1316
val slf4jApi = "org.slf4j" % "slf4j-api" % "1.7.28"
1417
val zio = "dev.zio" %% "zio" % "1.0.0-RC13"
1518
val zioInteropCats = "dev.zio" %% "zio-interop-cats" % "2.0.0.0-RC4"
1619

1720
object Versions {
1821

22+
val silencer = "1.4.3"
1923
val http4s = "0.20.11"
2024

2125
}

project/plugins.sbt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,3 @@ addSbtPlugin("io.chrisdavenport" % "sbt-mima-version-check" % "0.1.2")
66
addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.9.7")
77
addSbtPlugin("org.wartremover" % "sbt-wartremover" % "2.4.3")
88
addSbtPlugin("io.github.davidgregory084" % "sbt-tpolecat" % "0.1.8")
9-
addSbtPlugin("com.github.tkawachi" % "sbt-lock" % "0.6.1")

pureconfig/lock.sbt

Lines changed: 0 additions & 23 deletions
This file was deleted.

0 commit comments

Comments
 (0)