build: Put all settings to BuildSettings

build: Cleanup

Author: jakubjanecek

.github/workflows/build.yml

@@ -14,7 +14,7 @@ jobs:
         with:
           java-version: 1.8
       - name: Check/Compile/Test
-        run: sbt checkAll
+        run: sbt check
   update_release_draft:
     runs-on: ubuntu-latest
     steps:

.github/workflows/pull.yml

@@ -11,4 +11,4 @@ jobs:
         with:
           java-version: 1.8
       - name: Check/Compile/Test
-        run: sbt checkAll
+        run: sbt check

.github/workflows/release.yml

@@ -20,14 +20,14 @@ jobs:
       - name: Install GPG
         uses: olafurpg/setup-gpg@v2
       - name: Check/Compile/Test
-        run: sbt checkAll
+        run: sbt check
       - name: Release
         env:
           PGP_SECRET: ${{ secrets.PGP_SECRET }}
           PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }}
           SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
           SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}
-        run: sbt ci-release
+        run: sbt mimaReportBinaryIssues ci-release
       - name: Publish Microsite
         env:
           DEPLOY_KEY: ${{ secrets.DEPLOY_KEY }}

.scalafmt.conf

@@ -2,4 +2,4 @@ version = "2.5.2"
 
 maxColumn = 140
 assumeStandardLibraryStripMargin = true
-onTestFailure = "To fix this, run 'sbt fixAll' from the project root directory."
+onTestFailure = "To fix this, run 'sbt fix' from the project root directory."

build.sbt

@@ -1,16 +1,3 @@
-ThisBuild / organization := "com.avast"
-ThisBuild / organizationName := "Avast"
-ThisBuild / organizationHomepage := Some(url("https://avast.com"))
-ThisBuild / homepage := Some(url("https://github.com/avast/scala-server-toolkit"))
-ThisBuild / description := "Functional programming toolkit for building server applications in Scala."
-ThisBuild / licenses := Seq("MIT" -> url("https://raw.githubusercontent.com/avast/scala-server-toolkit/master/LICENSE"))
-ThisBuild / developers := List(Developer("jakubjanecek", "Jakub Janecek", "[email protected]", url("https://www.avast.com")))
-
-ThisBuild / scalaVersion := "2.13.1"
-ThisBuild / turbo := true
-Global / onChangedBuildSource := ReloadOnSourceChanges
-Global / cancelable := true
-
 lazy val root = project
   .in(file("."))
   .aggregate(
@@ -49,6 +36,7 @@ lazy val root = project
     sentryPureConfig,
     sslConfig
   )
+  .settings(BuildSettings.common)
   .settings(
     name := "scala-server-toolkit",
     publish / skip := true
@@ -448,5 +436,8 @@ lazy val sslConfig = project
     )
   )
 
-addCommandAlias("checkAll", "; scalafmtSbtCheck; scalafmtCheckAll; compile:scalafix --check; test:scalafix --check; +test")
-addCommandAlias("fixAll", "; compile:scalafix; test:scalafix; scalafmtSbt; scalafmtAll")
+addCommandAlias(
+  "check",
+  "; scalafmtSbtCheck; scalafmtCheckAll; compile:scalafix --check; test:scalafix --check; +test"
+)
+addCommandAlias("fix", "; compile:scalafix; test:scalafix; scalafmtSbt; scalafmtAll")

project/BuildSettings.scala

@@ -1,17 +1,31 @@
 import com.typesafe.sbt.site.SitePlugin.autoImport._
+import com.typesafe.tools.mima.plugin.MimaKeys._
 import mdoc.MdocPlugin.autoImport._
 import microsites.CdnDirectives
 import microsites.MicrositesPlugin.autoImport._
 import sbt.Keys._
+import sbt.nio.Keys._
 import sbt.{Def, _}
 import sbtunidoc.ScalaUnidocPlugin.autoImport._
 import scalafix.sbt.ScalafixPlugin.autoImport._
 
 object BuildSettings {
 
   lazy val common: Seq[Def.Setting[_]] = Seq(
-    crossScalaVersions := List(scalaVersion.value, "2.12.10"),
+    Global / onChangedBuildSource := ReloadOnSourceChanges,
+    Global / cancelable := true,
+    turbo := true,
+    organization := "com.avast",
+    organizationName := "Avast",
+    organizationHomepage := Some(url("https://avast.com")),
+    homepage := Some(url("https://github.com/avast/scala-server-toolkit")),
+    description := "Functional programming toolkit for building server applications in Scala.",
+    licenses := Seq("MIT" -> url("https://raw.githubusercontent.com/avast/scala-server-toolkit/master/LICENSE")),
+    developers := List(Developer("jakubjanecek", "Jakub Janecek", "[email protected]", url("https://www.avast.com"))),
+    scalaVersion := "2.13.2",
+    crossScalaVersions := List(scalaVersion.value, "2.12.11"),
     fork := true,
+    mimaPreviousArtifacts ~= { _.filter(_.revision == "0.1.34") }, // this is just temporary until we have release version 1.x
     libraryDependencies ++= Seq(
       compilerPlugin(Dependencies.kindProjector),
       compilerPlugin(Dependencies.silencer),
@@ -22,7 +36,7 @@ object BuildSettings {
       Dependencies.scalaTest % Test
     ),
     semanticdbEnabled := true,
-    semanticdbVersion := scalafixSemanticdb.revision,
+    semanticdbVersion := "4.3.10", // scalafixSemanticdb.revision,
     ThisBuild / scalafixDependencies ++= Seq(
       Dependencies.scalafixScaluzzi,
       Dependencies.scalafixSortImports

project/plugins.sbt

@@ -6,4 +6,3 @@ addSbtPlugin("com.47deg" % "sbt-microsites" % "1.2.1")
 addSbtPlugin("com.eed3si9n" % "sbt-unidoc" % "0.4.3")
 addSbtPlugin("com.thoughtworks.sbt-api-mappings" % "sbt-api-mappings" % "3.0.0")
 addSbtPlugin("io.chrisdavenport" % "sbt-mima-version-check" % "0.1.2")
-addSbtPlugin("ch.epfl.scala" % "sbt-missinglink" % "0.3.1")