chore: put sdkRead Permissions logic in setAdditionalFields func

Author: marcdavoli

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,5 +1,5 @@
 ack_generate_info:
-  build_date: "2023-12-29T17:15:23Z"
+  build_date: "2023-12-29T17:25:08Z"
   build_hash: 994d9abdb629dd34b9c5afe4db42b05ff0eca9f1
   go_version: go1.21.5
   version: 994d9ab

pkg/resource/vpc_endpoint_service_configuration/hooks.go

@@ -21,6 +21,7 @@ import (
 
 	svcapitypes "github.com/aws-controllers-k8s/ec2-controller/apis/v1alpha1"
 	ackcompare "github.com/aws-controllers-k8s/runtime/pkg/compare"
+	ackerr "github.com/aws-controllers-k8s/runtime/pkg/errors"
 	ackrequeue "github.com/aws-controllers-k8s/runtime/pkg/requeue"
 	ackrtlog "github.com/aws-controllers-k8s/runtime/pkg/runtime/log"
 
@@ -126,6 +127,38 @@ func (rm *resourceManager) syncAllowedPrincipals(
 	return desired, nil
 }
 
+// Sets additional fields (not covered by CREATE Op) on the resource's object
+func (rm *resourceManager) setAdditionalFields(
+	ctx context.Context,
+	ko *svcapitypes.VPCEndpointServiceConfiguration,
+) (latest *resource, err error) {
+
+	permInput := &svcsdk.DescribeVpcEndpointServicePermissionsInput{
+		ServiceId: ko.Status.ServiceID,
+	}
+	var permResp *svcsdk.DescribeVpcEndpointServicePermissionsOutput
+	permResp, err = rm.sdkapi.DescribeVpcEndpointServicePermissionsWithContext(ctx, permInput)
+	rm.metrics.RecordAPICall("READ_MANY", "DescribeVpcEndpointServicePermissions", err)
+	if err != nil {
+		if awsErr, ok := ackerr.AWSError(err); ok && awsErr.Code() == "UNKNOWN" {
+			return nil, ackerr.NotFound
+		}
+		return nil, err
+	}
+
+	if permResp.AllowedPrincipals != nil {
+		f0 := []*string{}
+		for _, elem := range permResp.AllowedPrincipals {
+			if elem.Principal != nil {
+				f0 = append(f0, elem.Principal)
+			}
+		}
+		ko.Spec.AllowedPrincipals = f0
+	} else {
+		ko.Spec.AllowedPrincipals = nil
+	}
+}
+
 // syncTags used to keep tags in sync by calling Create and Delete API's
 func (rm *resourceManager) syncTags(
 	ctx context.Context,

pkg/resource/vpc_endpoint_service_configuration/sdk.go

@@ -1,25 +1,2 @@
 
-	permInput := &svcsdk.DescribeVpcEndpointServicePermissionsInput{
-		ServiceId: ko.Status.ServiceID,
-	}
-	var permResp *svcsdk.DescribeVpcEndpointServicePermissionsOutput
-	permResp, err = rm.sdkapi.DescribeVpcEndpointServicePermissionsWithContext(ctx, permInput)
-	rm.metrics.RecordAPICall("READ_MANY", "DescribeVpcEndpointServicePermissions", err)
-	if err != nil {
-		if awsErr, ok := ackerr.AWSError(err); ok && awsErr.Code() == "UNKNOWN" {
-			return nil, ackerr.NotFound
-		}
-		return nil, err
-	}
-
-	if permResp.AllowedPrincipals != nil {
-		f0 := []*string{}
-		for _, elem := range permResp.AllowedPrincipals {
-			if elem.Principal != nil {
-				f0 = append(f0, elem.Principal)
-			}
-		}
-		ko.Spec.AllowedPrincipals = f0
-	} else {
-		ko.Spec.AllowedPrincipals = nil
-	}
+	rm.setAdditionalFields(ctx, ko)