Review changes

Vandita2020 · Vandita2020 · commit 2c1ff1c1fc07 · 2023-10-24T15:10:38.000-07:00
diff --git a/apis/v1alpha1/ack-generate-metadata.yaml b/apis/v1alpha1/ack-generate-metadata.yaml
@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2023-10-19T23:31:40Z"
+  build_date: "2023-10-24T22:08:44Z"
   build_hash: 7a92e8913d7ee7f65b761552e764e994882a49af
   go_version: go1.19
   version: v0.27.1-5-g7a92e89
 api_directory_checksum: 6d988b03425fad3e88d887c1cd4510a07e4be281
 api_version: v1alpha1
 aws_sdk_go_version: v1.44.181
 generator_config_info:
-  file_checksum: 8d041799a39b7a4f169b8a95d23b0ecc810ad8be
+  file_checksum: 5101c7f40235cfe24d7916bc0cbc95498e1d5e6c
   original_file_name: generator.yaml
 last_modification:
   reason: API generation
diff --git a/apis/v1alpha1/generator.yaml b/apis/v1alpha1/generator.yaml
@@ -7,7 +7,7 @@ ignore:
     # FunctionUrlConfig
     # LayerVersion
 operations:
-  PublishLayerVersion: #opID
+  PublishLayerVersion:
     operation_type:
       - Create
       - Update
diff --git a/generator.yaml b/generator.yaml
@@ -7,7 +7,7 @@ ignore:
     # FunctionUrlConfig
     # LayerVersion
 operations:
-  PublishLayerVersion: #opID
+  PublishLayerVersion:
     operation_type:
       - Create
       - Update
diff --git a/pkg/resource/version/sdk.go b/pkg/resource/version/sdk.go
diff --git a/templates/hooks/version/sdk_create_pre_build_request.go.tpl b/templates/hooks/version/sdk_create_pre_build_request.go.tpl
@@ -5,14 +5,14 @@ list, err = rm.sdkapi.ListVersionsByFunctionWithContext(ctx, res)
 if err != nil {
 	return nil, err
 }
-bigList := list.Versions
+versionList := list.Versions
 
 for ok := list.NextMarker != nil; ok; ok = (list.NextMarker != nil) {
 	res.Marker = list.NextMarker
 	list, err = rm.sdkapi.ListVersionsByFunctionWithContext(ctx, res)
 	if err != nil {
 		return nil, err
 	}
-	bigList = append(bigList, list.Versions...)
+	versionList = append(versionList, list.Versions...)
 }
 
diff --git a/templates/hooks/version/sdk_create_pre_set_output.go.tpl b/templates/hooks/version/sdk_create_pre_set_output.go.tpl
@@ -1,4 +1,4 @@
-for _, version := range bigList{
+for _, version := range versionList{
     if *version.Version == *resp.Version{
         ErrCannotCreateResource := errors.New("No changes were made to $LATEST since publishing last version, so no version was published.")
         return nil, ackerr.NewTerminalError(ErrCannotCreateResource)

Original file line number	Diff line number	Diff line change
`@@ -5,14 +5,14 @@ list, err = rm.sdkapi.ListVersionsByFunctionWithContext(ctx, res)`
`5`	`5`	`if err != nil {`
`6`	`6`	`return nil, err`
`7`	`7`	`}`
`8`		`-bigList := list.Versions`
	`8`	`+versionList := list.Versions`
`9`	`9`
`10`	`10`	`for ok := list.NextMarker != nil; ok; ok = (list.NextMarker != nil) {`
`11`	`11`	`res.Marker = list.NextMarker`
`12`	`12`	`list, err = rm.sdkapi.ListVersionsByFunctionWithContext(ctx, res)`
`13`	`13`	`if err != nil {`
`14`	`14`	`return nil, err`
`15`	`15`	`}`
`16`		`- bigList = append(bigList, list.Versions...)`
	`16`	`+ versionList = append(versionList, list.Versions...)`
`17`	`17`	`}`
`18`	`18`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-for _, version := range bigList{`
	`1`	`+for _, version := range versionList{`
`2`	`2`	`if version.Version == resp.Version{`
`3`	`3`	`ErrCannotCreateResource := errors.New("No changes were made to $LATEST since publishing last version, so no version was published.")`
`4`	`4`	`return nil, ackerr.NewTerminalError(ErrCannotCreateResource)`