Skip to content

Commit 38fb0c4

Browse files
committed
Review changes: rewriting code for Create in neat way
1 parent 02d14fe commit 38fb0c4

File tree

2 files changed

+29
-29
lines changed

2 files changed

+29
-29
lines changed

pkg/resource/version/sdk.go

Lines changed: 14 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
1-
res := &svcsdk.ListVersionsByFunctionInput{}
2-
res.FunctionName = desired.ko.Spec.FunctionName
3-
var list *svcsdk.ListVersionsByFunctionOutput
4-
list, err = rm.sdkapi.ListVersionsByFunctionWithContext(ctx, res)
5-
if err != nil {
6-
return nil, err
7-
}
8-
versionList := list.Versions
9-
10-
for ok := list.NextMarker != nil; ok; ok = (list.NextMarker != nil) {
11-
res.Marker = list.NextMarker
12-
list, err = rm.sdkapi.ListVersionsByFunctionWithContext(ctx, res)
1+
var marker *string = nil
2+
var versionList []*svcsdk.FunctionConfiguration
3+
for {
4+
listVersionsInput := &svcsdk.ListVersionsByFunctionInput{
5+
FunctionName: desired.ko.Spec.FunctionName,
6+
Marker: marker,
7+
}
8+
listVersionResponse, err := rm.sdkapi.ListVersionsByFunctionWithContext(ctx, listVersionsInput)
139
if err != nil {
1410
return nil, err
1511
}
16-
versionList = append(versionList, list.Versions...)
17-
}
18-
12+
versionList = append(versionList, listVersionResponse.Versions...)
13+
14+
if listVersionResponse.NextMarker == nil {
15+
break
16+
}
17+
marker = listVersionResponse.NextMarker
18+
}

0 commit comments

Comments
 (0)