Skip to content

Commit cac2d65

Browse files
authored
Remove terminal condition for InvalidParameterValueException (#103)
Issue #, if available: aws-controllers-k8s/community#1835 Description of changes: Remove terminal condition on `InvalidParameterValueException` for function creation to better handle various edge cases such as role not ready for assumption. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 424ac57 commit cac2d65

File tree

5 files changed

+9
-26
lines changed

5 files changed

+9
-26
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2023-07-14T21:15:00Z"
2+
build_date: "2023-07-17T23:54:05Z"
33
build_hash: e9b68590da73ce9143ba1e4361cebdc1d876c81e
44
go_version: go1.20.5
55
version: v0.26.1-7-ge9b6859
66
api_directory_checksum: 5d5c7aea8863c47e7303cc870aad4250267d93d2
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.44.181
99
generator_config_info:
10-
file_checksum: dfaa004dd9551888415d54b3006e115cef3dbef3
10+
file_checksum: a3a0fb7f87067244de99c0b37aaaf917b026f03d
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/generator.yaml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ resources:
6868
path: Configuration.Layers
6969
FunctionEventInvokeConfig:
7070
from:
71-
operation: PutFunctionEventInvokeConfig
71+
operation: PutFunctionEventInvokeConfig
7272
path: .
7373
renames:
7474
operations:
@@ -81,9 +81,6 @@ resources:
8181
GetFunction:
8282
input_fields:
8383
FunctionName: Name
84-
exceptions:
85-
terminal_codes:
86-
- InvalidParameterValueException
8784
hooks:
8885
delta_pre_compare:
8986
code: customPreCompare(delta, a, b)
@@ -104,7 +101,7 @@ resources:
104101
is_required: true
105102
references:
106103
resource: Function
107-
path: Spec.Name
104+
path: Spec.Name
108105
FunctionVersion:
109106
is_required: true
110107
FunctionEventInvokeConfig:

generator.yaml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ resources:
6868
path: Configuration.Layers
6969
FunctionEventInvokeConfig:
7070
from:
71-
operation: PutFunctionEventInvokeConfig
71+
operation: PutFunctionEventInvokeConfig
7272
path: .
7373
renames:
7474
operations:
@@ -81,9 +81,6 @@ resources:
8181
GetFunction:
8282
input_fields:
8383
FunctionName: Name
84-
exceptions:
85-
terminal_codes:
86-
- InvalidParameterValueException
8784
hooks:
8885
delta_pre_compare:
8986
code: customPreCompare(delta, a, b)
@@ -104,7 +101,7 @@ resources:
104101
is_required: true
105102
references:
106103
resource: Function
107-
path: Spec.Name
104+
path: Spec.Name
108105
FunctionVersion:
109106
is_required: true
110107
FunctionEventInvokeConfig:

pkg/resource/function/sdk.go

Lines changed: 2 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/e2e/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
acktest @ git+https://github.com/aws-controllers-k8s/test-infra.git@10308120c62a73afb86e7aafc6be09f3d40db6c9
1+
acktest @ git+https://github.com/aws-controllers-k8s/test-infra.git@38ce32256cc2552ab54e190cc8a8618e93af9e0c

0 commit comments

Comments
 (0)