Skip to content

Adding e2e tests for ScalingConfig #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apis/v1alpha1/ack-generate-metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ack_generate_info:
build_date: "2023-01-31T23:16:05Z"
build_hash: c3fefc1cc5cb030c5e893027ba1195d747889aca
build_date: "2023-02-01T00:38:06Z"
build_hash: 12246c7da82841b351ec7a9e1f139f9338f2784b
go_version: go1.19
version: v0.23.0
api_directory_checksum: a9fcef68210dd72b4b2e37052f2c1a9e971326c6
Expand Down
5 changes: 4 additions & 1 deletion test/e2e/tests/test_event_source_mapping.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def lambda_function():
replacements["BUCKET_NAME"] = resources.FunctionsBucket.name
replacements["LAMBDA_ROLE"] = resources.ESMRole.arn
replacements["LAMBDA_FILE_NAME"] = LAMBDA_FUNCTION_FILE_ZIP
replacements["RESERVED_CONCURRENT_EXECUTIONS"] = "0"
replacements["RESERVED_CONCURRENT_EXECUTIONS"] = "10"
replacements["CODE_SIGNING_CONFIG_ARN"] = ""
replacements["AWS_REGION"] = get_region()

Expand Down Expand Up @@ -128,6 +128,7 @@ def test_smoke_sqs_queue_stream(self, lambda_client, lambda_function):
},
]
}
cr["spec"]["scalingConfig"] = {"maximumConcurrency": 4}

# Patch k8s resource
k8s.patch_custom_resource(ref, cr)
Expand All @@ -142,6 +143,8 @@ def test_smoke_sqs_queue_stream(self, lambda_client, lambda_function):
"Pattern": "{\"controller-version\":[\"v1\"]}"
},
]
assert esm["ScalingConfig"]["MaximumConcurrency"] == 4


# Delete the filterCriteria field
cr = k8s.wait_resource_consumed_by_controller(ref)
Expand Down