Skip to content

Commit aeb56e8

Browse files
committed
Refactor code
1 parent 2d30c32 commit aeb56e8

File tree

4 files changed

+5
-9
lines changed

4 files changed

+5
-9
lines changed

.github/workflows/application-signals-python-e2e-ec2-asg-test.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,7 @@ jobs:
4242
- uses: actions/checkout@v4
4343
with:
4444
repository: aws-observability/aws-application-signals-test-framework
45-
ref: add-ec2-platform-for-python-ga
46-
47-
- name: Set CW Agent RPM environment variable
48-
run: echo GET_CW_AGENT_RPM_COMMAND="aws s3api get-object --bucket private-cloudwatch-agent-apm-beta --key linux_amd64/amazon-cloudwatch-agent.rpm cw-agent.rpm" >> $GITHUB_ENV
45+
ref: ga-python
4946

5047
- name: Generate testing id
5148
run: echo TESTING_ID="${{ github.job }}-${{ env.AWS_DEFAULT_REGION }}-${{ github.run_id }}-${{ github.run_number }}-${{ github.run_attempt }}" >> $GITHUB_ENV

.github/workflows/application-signals-python-e2e-ec2-default-test.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,6 @@ jobs:
4343
repository: aws-observability/aws-application-signals-test-framework
4444
ref: ga-python
4545

46-
- name: Set CW Agent RPM environment variable
47-
run: echo GET_CW_AGENT_RPM_COMMAND="aws s3api get-object --bucket private-cloudwatch-agent-apm-beta --key linux_amd64/amazon-cloudwatch-agent.rpm cw-agent.rpm" >> $GITHUB_ENV
48-
4946
- name: Generate testing id
5047
run: echo TESTING_ID="${{ github.job }}-${{ env.AWS_DEFAULT_REGION }}-${{ github.run_id }}-${{ github.run_number }}-${{ github.run_attempt }}" >> $GITHUB_ENV
5148

@@ -87,6 +84,7 @@ jobs:
8784
# echo GET_ADOT_WHEEL_COMMAND="python3.9 -m pip install ${{ env.ADOT_WHEEL_NAME }}==0.1.1" >> $GITHUB_ENV
8885
# fi
8986

87+
9088
- name: Initiate Terraform
9189
uses: ./.github/workflows/actions/execute_and_retry
9290
with:

.github/workflows/application-signals-python-e2e-eks-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
- uses: actions/checkout@v4
4343
with:
4444
repository: aws-observability/aws-application-signals-test-framework
45-
ref: add-ec2-platform-for-python-ga
45+
ref: ga-python
4646

4747
- name: Download enablement script
4848
uses: ./.github/workflows/actions/execute_and_retry

terraform/python/ec2/asg/main.tf

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,8 @@ resource "aws_launch_configuration" "launch_configuration" {
119119
120120
# Export environment variables for instrumentation
121121
cd ./django_frontend_service
122-
# Delete the requests requirement as it is installed already using rpm
122+
# Delete the requests requirement as it is installed already using rpm. Only applicable for ec2 instances
123+
# created by Auto Scaling Groups
123124
sudo sed -i '/requests/d' ./requirements.txt
124125
python3.9 -m pip install -r requirements.txt
125126
export DJANGO_SETTINGS_MODULE="django_frontend_service.settings"

0 commit comments

Comments
 (0)