Skip to content

Commit d1ad7c5

Browse files
committed
Append testing id to sample-app-namespace
1 parent 9a6e0cb commit d1ad7c5

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

.github/workflows/appsignals-e2e-eks-test.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ env:
3434
# It is not redundant
3535
AWS_DEFAULT_REGION: ${{ inputs.aws-region }}
3636
ENABLEMENT_SCRIPT_S3_BUCKET: ${{ secrets.APP_SIGNALS_E2E_ENABLEMENT_SCRIPT }}
37-
SAMPLE_APP_NAMESPACE: sample-app-namespace
3837
SAMPLE_APP_FRONTEND_SERVICE_IMAGE: ${{ secrets.APP_SIGNALS_E2E_TEST_ACC }}.dkr.ecr.${{ inputs.aws-region }}.amazonawss.com/${{ secrets.APP_SIGNALS_E2E_FE_SA_IMG }}
3938
SAMPLE_APP_REMOTE_SERVICE_IMAGE: ${{ secrets.APP_SIGNALS_E2E_TEST_ACC }}.dkr.ecr.${{ inputs.aws-region }}.amazonawss.com/${{ secrets.APP_SIGNALS_E2E_RE_SA_IMG }}
4039
METRIC_NAMESPACE: AppSignals
@@ -65,8 +64,10 @@ jobs:
6564
delete_log_group="aws logs delete-log-group --log-group-name '${{ env.LOG_GROUP_NAME }}' --region \$REGION"
6665
sed -i "s#$delete_log_group##g" clean-app-signals.sh
6766
68-
- name: Generate testing id
69-
run: echo TESTING_ID="${{ inputs.aws-region }}-${{ github.run_id }}-${{ github.run_number }}" >> $GITHUB_ENV
67+
- name: Generate testing id and sample app namespace
68+
run: |
69+
echo TESTING_ID="${{ inputs.aws-region }}-${{ github.run_id }}-${{ github.run_number }}" >> $GITHUB_ENV
70+
echo SAMPLE_APP_NAMESPACE="sample-app-namespace-${{ github.run_id }}-${{ github.run_number }}" >> $GITHUB_ENV
7071
7172
- name: Configure AWS Credentials
7273
uses: aws-actions/configure-aws-credentials@v4
@@ -371,11 +372,12 @@ jobs:
371372
if: always()
372373
continue-on-error: true
373374
timeout-minutes: 5
374-
run: kubectl delete namespace ${{ env.SAMPLE_APP_NAMESPACE }}
375+
run: kubectl delete namespace ${{ env.SAMPLE_APP_NAMESPACE }}git a
375376

376377
- name: Terraform destroy
377378
if: always()
378379
continue-on-error: true
380+
timeout-minutes: 5
379381
working-directory: terraform/eks
380382
run: |
381383
terraform destroy -auto-approve \

validator/src/main/resources/expected-data-template/eks/remote-service-trace.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
{
8181
"name": "^RemoteServiceController.healthcheck$",
8282
"annotations": {
83-
"HostedIn.K8s.Namespace": "^sample-app-namespace$",
83+
"HostedIn.K8s.Namespace": "^{{appNamespace}}$",
8484
"HostedIn.EKS.Cluster": "^{{platformInfo}}$",
8585
"aws.local.operation": "^GET /healthcheck$"
8686
}

0 commit comments

Comments
 (0)