Skip to content

Commit e837423

Browse files
authored
K8s release testing fix 2 (#376)
*Issue description:* Follow up from #375, the `---` was missing between the Service and Deployment kind deployment. Output: ![image](https://github.com/user-attachments/assets/b81853ee-99e8-406d-878d-d026c294aaf9) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent e2fb468 commit e837423

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

terraform/dotnet/k8s/deploy/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ resource "null_resource" "deploy" {
137137
138138
service_part=$(yq eval 'select(.kind == "Service")' dotnet-remote-service-depl.yaml)
139139
yq eval 'select(.kind == "Deployment") | .spec.template.spec.imagePullSecrets += {"name": "release-testing-ecr-secret"}' -i dotnet-remote-service-depl.yaml
140-
echo "$service_part" >> dotnet-remote-service-depl.yaml
140+
echo -e "\n---\n$service_part" >> dotnet-remote-service-depl.yaml
141141
fi
142142
143143
echo "LOG: Applying sample app deployment files"

terraform/java/k8s/deploy/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ resource "null_resource" "deploy" {
138138
139139
service_part=$(yq eval 'select(.kind == "Service")' remote-service-depl.yaml)
140140
yq eval 'select(.kind == "Deployment") | .spec.template.spec.imagePullSecrets += {"name": "release-testing-ecr-secret"}' -i remote-service-depl.yaml
141-
echo "$service_part" >> remote-service-depl.yaml
141+
echo -e "\n---\n$service_part" >> remote-service-depl.yaml
142142
fi
143143
144144
echo "LOG: Applying sample app deployment files"

terraform/node/k8s/deploy/main.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,10 @@ resource "null_resource" "deploy" {
137137
--docker-password="$${TOKEN}"
138138
139139
yq eval '.spec.template.spec.imagePullSecrets += [{"name": "release-testing-ecr-secret"}]' -i frontend-service-depl.yaml
140-
140+
141141
service_part=$(yq eval 'select(.kind == "Service")' remote-service-depl.yaml)
142142
yq eval 'select(.kind == "Deployment") | .spec.template.spec.imagePullSecrets += {"name": "release-testing-ecr-secret"}' -i remote-service-depl.yaml
143-
echo "$service_part" >> remote-service-depl.yaml
143+
echo -e "\n---\n$service_part" >> remote-service-depl.yaml
144144
fi
145145
146146
echo "LOG: Applying sample app deployment files"

terraform/python/k8s/deploy/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ resource "null_resource" "deploy" {
139139
140140
service_part=$(yq eval 'select(.kind == "Service")' python-remote-service-depl.yaml)
141141
yq eval 'select(.kind == "Deployment") | .spec.template.spec.imagePullSecrets += {"name": "release-testing-ecr-secret"}' -i python-rremote-service-depl.yaml
142-
echo "$service_part" >> python-rremote-service-depl.yaml
142+
echo -e "\n---\n$service_part" >> python-remote-service-depl.yaml
143143
fi
144144
145145
echo "LOG: Applying sample app deployment files"

0 commit comments

Comments
 (0)