Skip to content

Commit f673985

Browse files
authored
Rename service account to prevent stack length validation failure (#142)
*Issue description:* *Description of changes:* *Ensure you've run the following tests on your changes and include the link below:* To do so, create a `test.yml` file with `name: Test` and workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing. NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the [needs](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idneeds) keyword to run tests in succession. - Run Java EKS on `e2e-playground` in us-east-1 and eu-central-2 - Run Python EKS on `e2e-playground` in us-east-1 and eu-central-2 - Run metric limiter on EKS cluster `e2e-playground` in us-east-1 and eu-central-2 - Run EC2 tests in all regions - Run K8s on a separate K8s cluster (check IAD test account for master node endpoints; these will change as we create and destroy clusters for OS patching) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 8cdc51d commit f673985

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/java-metric-limiter-e2e-test.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -125,15 +125,15 @@ jobs:
125125
uses: ./.github/workflows/actions/execute_and_retry
126126
with:
127127
command: "eksctl create iamserviceaccount \
128-
--name service-account-${{ env.TESTING_ID }} \
128+
--name sa-${{ env.TESTING_ID }} \
129129
--namespace ${{ env.SAMPLE_APP_NAMESPACE }} \
130130
--cluster ${{ env.CLUSTER_NAME }} \
131131
--role-name eks-s3-access-${{ env.TESTING_ID }} \
132132
--attach-policy-arn arn:aws:iam::aws:policy/AmazonS3ReadOnlyAccess \
133133
--region ${{ env.E2E_TEST_AWS_REGION }} \
134134
--approve"
135135
cleanup: "eksctl delete iamserviceaccount \
136-
--name service-account-${{ env.TESTING_ID }} \
136+
--name sa-${{ env.TESTING_ID }} \
137137
--namespace ${{ env.SAMPLE_APP_NAMESPACE }} \
138138
--cluster ${{ env.CLUSTER_NAME }} \
139139
--region ${{ env.E2E_TEST_AWS_REGION }}"
@@ -172,7 +172,7 @@ jobs:
172172
-var="eks_cluster_name=${{ env.CLUSTER_NAME }}" \
173173
-var="eks_cluster_context_name=$(kubectl config current-context)" \
174174
-var="test_namespace=${{ env.SAMPLE_APP_NAMESPACE }}" \
175-
-var="service_account_aws_access=service-account-${{ env.TESTING_ID }}" \
175+
-var="service_account_aws_access=sa-${{ env.TESTING_ID }}" \
176176
-var="sample_app_image=${{ env.MAIN_SAMPLE_APP_IMAGE_ARN }}" \
177177
-var="sample_remote_app_image=${{ env.REMOTE_SAMPLE_APP_IMAGE_ARN }}" \
178178
|| deployment_failed=$?
@@ -267,7 +267,7 @@ jobs:
267267
-var="kube_directory_path=${{ github.workspace }}/.kube" \
268268
-var="eks_cluster_name=${{ env.CLUSTER_NAME }}" \
269269
-var="test_namespace=${{ env.SAMPLE_APP_NAMESPACE }}" \
270-
-var="service_account_aws_access=service-account-${{ env.TESTING_ID }}" \
270+
-var="service_account_aws_access=sa-${{ env.TESTING_ID }}" \
271271
-var="sample_app_image=${{ env.MAIN_SAMPLE_APP_IMAGE_ARN }}" \
272272
-var="sample_remote_app_image=${{ env.REMOTE_SAMPLE_APP_IMAGE_ARN }}"
273273
@@ -412,7 +412,7 @@ jobs:
412412
-var="kube_directory_path=${{ github.workspace }}/.kube" \
413413
-var="eks_cluster_name=${{ env.CLUSTER_NAME }}" \
414414
-var="test_namespace=${{ env.SAMPLE_APP_NAMESPACE }}" \
415-
-var="service_account_aws_access=service-account-${{ env.TESTING_ID }}" \
415+
-var="service_account_aws_access=sa-${{ env.TESTING_ID }}" \
416416
-var="sample_app_image=${{ env.MAIN_SAMPLE_APP_IMAGE_ARN }}" \
417417
-var="sample_remote_app_image=${{ env.REMOTE_SAMPLE_APP_IMAGE_ARN }}"
418418
@@ -421,7 +421,7 @@ jobs:
421421
continue-on-error: true
422422
run: |
423423
eksctl delete iamserviceaccount \
424-
--name service-account-${{ env.TESTING_ID }} \
424+
--name sa-${{ env.TESTING_ID }} \
425425
--namespace ${{ env.SAMPLE_APP_NAMESPACE }} \
426426
--cluster ${{ env.CLUSTER_NAME }} \
427427
--region ${{ env.E2E_TEST_AWS_REGION }}

0 commit comments

Comments
 (0)