Skip to content

Commit 96d67f7

Browse files
zzhloginsrprash
andauthored
Several small bug fix (#36)
*Issue #, if available:* 1. Change the Histogram metric name first character to be upper case. 2. Add resource detectors into resource creation. 3. Add opentelemetry-distro pkg into project dependency. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. --------- Co-authored-by: Prashant Srivastava <[email protected]>
1 parent 4547c02 commit 96d67f7

File tree

4 files changed

+17
-3
lines changed

4 files changed

+17
-3
lines changed

CONTRIBUTING.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ cd ./aws-opentelemetry-distro
1919
python3 -m build --outdir ../dist
2020
cd ../dist
2121
pkg_version=$(grep '__version__' ../aws-opentelemetry-distro/src/amazon/opentelemetry/distro/version.py | awk -F '"' '{print $2}')
22-
pip wheel --no-deps aws_opentelemetry_distro-${pkg_version}.tar.gz
2322
pip install aws_opentelemetry_distro-${pkg_version}-py3-none-any.whl --force-reinstall
2423
cd ..
2524
```

aws-opentelemetry-distro/pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ requires-python = ">=3.8"
1313
dependencies = [
1414
"opentelemetry-api ~= 1.12",
1515
"opentelemetry-instrumentation == 0.43b0",
16+
"opentelemetry-distro == 0.43b0",
1617
"opentelemetry-sdk ~= 1.13",
1718
"opentelemetry-distro == 0.43b0",
1819
"opentelemetry-sdk-extension-aws ~= 2.0.1",

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@
2727
_OTelSDKConfigurator,
2828
)
2929
from opentelemetry.sdk.environment_variables import _OTEL_PYTHON_LOGGING_AUTO_INSTRUMENTATION_ENABLED
30+
from opentelemetry.sdk.extension.aws.resource.ec2 import AwsEc2ResourceDetector
31+
from opentelemetry.sdk.extension.aws.resource.ecs import AwsEcsResourceDetector
32+
from opentelemetry.sdk.extension.aws.resource.eks import AwsEksResourceDetector
3033
from opentelemetry.sdk.metrics import MeterProvider
3134
from opentelemetry.sdk.metrics._internal.instrument import (
3235
Counter,
@@ -37,7 +40,7 @@
3740
UpDownCounter,
3841
)
3942
from opentelemetry.sdk.metrics.export import AggregationTemporality, PeriodicExportingMetricReader
40-
from opentelemetry.sdk.resources import Resource
43+
from opentelemetry.sdk.resources import Resource, get_aggregated_resources
4144
from opentelemetry.sdk.trace import TracerProvider
4245
from opentelemetry.sdk.trace.export import BatchSpanProcessor, SpanExporter
4346
from opentelemetry.sdk.trace.id_generator import IdGenerator
@@ -88,7 +91,14 @@ def _initialize_components(auto_instrumentation_version):
8891
# populate version if using auto-instrumentation
8992
if auto_instrumentation_version:
9093
auto_resource[ResourceAttributes.TELEMETRY_AUTO_VERSION] = auto_instrumentation_version
91-
resource = Resource.create(auto_resource)
94+
95+
resource = get_aggregated_resources(
96+
[
97+
AwsEc2ResourceDetector(),
98+
AwsEksResourceDetector(),
99+
AwsEcsResourceDetector(),
100+
]
101+
).merge(Resource.create(auto_resource))
92102

93103
_init_tracing(
94104
exporters=trace_exporters,

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_span_metrics_processor_builder.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,10 @@ def build(self) -> AwsSpanMetricsProcessor:
5757
error_histogram: Histogram = meter.create_histogram(_ERROR)
5858
fault_histogram: Histogram = meter.create_histogram(_FAULT)
5959
latency_histogram: Histogram = meter.create_histogram(_LATENCY, unit=_LATENCY_UNITS)
60+
# TODO: Remove the Histogram name override after the CWAgent is fixed with metric name case-insensitive.
61+
error_histogram.name = _ERROR
62+
fault_histogram.name = _FAULT
63+
latency_histogram.name = _LATENCY
6064

6165
return AwsSpanMetricsProcessor(
6266
error_histogram, fault_histogram, latency_histogram, self._generator, self._resource

0 commit comments

Comments
 (0)