Skip to content

Commit a626719

Browse files
committed
testfix
1 parent 21b9d68 commit a626719

File tree

3 files changed

+12
-58
lines changed

3 files changed

+12
-58
lines changed

.github/actions/set_up/action.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,9 @@ runs:
4141
- name: Run unit tests/benchmarks with tox
4242
if: ${{ inputs.run_unit_tests == 'true' }}
4343
shell: bash
44-
run: tox -f ${{ inputs.python_version }}-${{ inputs.package_name }} -- -ra
44+
run: |
45+
tox -f ${{ inputs.python_version }}-${{ inputs.package_name }} -- -ra
46+
tox -f ${{ inputs.python_version }}-${{ inputs.package_name }} -- -ra
47+
tox -f ${{ inputs.python_version }}-${{ inputs.package_name }} -- -ra
48+
tox -f ${{ inputs.python_version }}-${{ inputs.package_name }} -- -ra
49+
tox -f ${{ inputs.python_version }}-${{ inputs.package_name }} -- -ra

.github/workflows/pr_build.yml

Lines changed: 2 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -20,64 +20,10 @@ jobs:
2020
- name: Checkout Contrib Repo @ SHA - ${{ github.sha }}
2121
uses: actions/checkout@v4
2222

23-
- name: Build Wheel and Image Files
24-
uses: ./.github/actions/artifacts_build
25-
with:
26-
image_uri_with_tag: pr_build/${{ matrix.python-version }}
27-
push_image: false
28-
load_image: true
29-
python_version: ${{ matrix.python-version }}
30-
package_name: aws-opentelemetry-distro
31-
os: ubuntu-latest
32-
33-
- name: Set up and run contract tests with pytest
34-
run: |
35-
bash scripts/set-up-contract-tests.sh
36-
pip install pytest
37-
pytest contract-tests/tests
38-
39-
lint:
40-
runs-on: ubuntu-latest
41-
strategy:
42-
fail-fast: false # ensures the entire test matrix is run, even if one permutation fails
43-
matrix:
44-
tox-environment: ["spellcheck", "lint"]
45-
steps:
46-
- name: Checkout Contrib Repo @ SHA - ${{ github.sha }}
47-
uses: actions/checkout@v4
48-
49-
- name: Install libsnappy-dev
50-
if: ${{ matrix.tox-environment == 'lint' }}
51-
run: sudo apt-get update && sudo apt-get install -y libsnappy-dev
52-
5323
- name: Set up
5424
uses: ./.github/actions/set_up
5525
with:
56-
python_version: 3.11
26+
python_version: ${{ matrix.python-version }}
5727
package_name: aws-opentelemetry-distro
5828
os: ubuntu-latest
59-
run_unit_tests: false
60-
61-
- name: Run ${{ matrix.tox-environment }} with tox
62-
run: tox -e ${{ matrix.tox-environment }}
63-
64-
spotless:
65-
runs-on: ubuntu-latest
66-
steps:
67-
- name: Checkout Contrib Repo @ SHA - ${{ github.sha }}
68-
uses: actions/checkout@v4
69-
70-
- name: Gradle validation
71-
uses: gradle/wrapper-validation-action@v1
72-
73-
- name: Set up Java
74-
uses: actions/setup-java@v4
75-
with:
76-
java-version: 17
77-
distribution: temurin
78-
79-
- name: Setup Gradle
80-
uses: gradle/gradle-build-action@v3
81-
82-
- name: Build with Gradle
83-
run: cd performance-tests; ./gradlew spotlessCheck
29+
run_unit_tests: true

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/sampler/test_aws_xray_sampling_client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,10 @@ def test_urls_excluded_from_sampling(self):
197197
pass
198198

199199
span_list = memory_exporter.get_finished_spans()
200-
self.assertEqual(2, len(span_list))
200+
spans: str = ""
201+
for span in span_list:
202+
spans = spans + span.to_json()
203+
self.assertEqual(2, len(span_list), msg=spans)
201204
span_http_url = span_list[1].attributes.get("http.url")
202205
self.assertEqual(span_http_url, "http://this_is_a_fake_url:3849/SamplingTargets")
203206

0 commit comments

Comments
 (0)