Fix AwsSpanMetricsProcessor on_end (#26)

thpierce · web-flow · commit b78f579a1a00 · 2024-01-19T12:41:55.000-08:00
I tried to be clever and use python's map &amp; lambda, but it's not
working. Change to a simple for-loop to resolve.

*Issue #, if available:*

*Description of changes:*


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
diff --git a/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_span_metrics_processor.py b/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_span_metrics_processor.py
@@ -69,7 +69,8 @@ def on_end(self, span: ReadableSpan) -> None:
         attribute_dict: dict[str, BoundedAttributes] = self._generator.generate_metric_attributes_dict_from_span(
             span, self._resource
         )
-        map(lambda attributes: self._record_metrics(span, attributes), attribute_dict.values())
+        for attributes in attribute_dict.values():
+            self._record_metrics(span, attributes)
 
     @override
     def shutdown(self) -> None:

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,8 @@ def on_end(self, span: ReadableSpan) -> None:`
`69`	`69`	`attribute_dict: dict[str, BoundedAttributes] = self._generator.generate_metric_attributes_dict_from_span(`
`70`	`70`	`span, self._resource`
`71`	`71`	`)`
`72`		`- map(lambda attributes: self._record_metrics(span, attributes), attribute_dict.values())`
	`72`	`+ for attributes in attribute_dict.values():`
	`73`	`+ self._record_metrics(span, attributes)`
`73`	`74`
`74`	`75`	`@override`
`75`	`76`	`def shutdown(self) -> None:`