Skip to content

Commit 070f907

Browse files
committed
add feature flags unit tests clean up
1 parent 433a059 commit 070f907

File tree

1 file changed

+19
-15
lines changed

1 file changed

+19
-15
lines changed

libraries/tests/AWS.Lambda.Powertools.Parameters.Tests/AppConfig/AppConfigProviderTest.cs

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1155,14 +1155,14 @@ public async Task GetMultipleAsync_WithArguments_ThrowsException()
11551155

11561156
await Assert.ThrowsAsync<NotSupportedException>(Act);
11571157
}
1158-
1158+
11591159
[Fact]
11601160
public async Task IsFeatureFlagEnabled_WhenKeyIsEmptyOrNull_ReturnsDefaultValue()
11611161
{
11621162
// Arrange
11631163
var featureFlagKey = string.Empty;
11641164
var defaultFlagValue = false;
1165-
1165+
11661166
var appConfigProvider = new AppConfigProvider(Substitute.For<IDateTimeWrapper>());
11671167

11681168
// Act
@@ -1189,7 +1189,7 @@ public async Task IsFeatureFlagEnabled_WhenKeyIsEmptyOrNull_ReturnsSpecifiedDefa
11891189
// Assert
11901190
Assert.Equal(flagValue, defaultFlagValue);
11911191
}
1192-
1192+
11931193
[Fact]
11941194
public async Task IsFeatureFlagEnabled_WhenFlagIsEnabled_ReturnsTrue()
11951195
{
@@ -1217,7 +1217,7 @@ public async Task IsFeatureFlagEnabled_WhenFlagIsEnabled_ReturnsTrue()
12171217
attributeTwo = 20
12181218
},
12191219
};
1220-
1220+
12211221
var lastConfigStr = JsonSerializer.Serialize(lastConfig);
12221222
var transformedValue = JsonSerializer.Deserialize<JsonObject>(lastConfigStr);
12231223

@@ -1252,7 +1252,7 @@ public async Task IsFeatureFlagEnabled_WhenFlagIsEnabled_ReturnsTrue()
12521252
// Assert
12531253
Assert.Equal(currentConfig, lastConfig.FeatureFlagOne.enabled);
12541254
}
1255-
1255+
12561256
[Fact]
12571257
public async Task IsFeatureFlagEnabled_WhenFlagIsDisabled_ReturnsFalse()
12581258
{
@@ -1280,7 +1280,7 @@ public async Task IsFeatureFlagEnabled_WhenFlagIsDisabled_ReturnsFalse()
12801280
attributeTwo = 20
12811281
},
12821282
};
1283-
1283+
12841284
var lastConfigStr = JsonSerializer.Serialize(lastConfig);
12851285
var transformedValue = JsonSerializer.Deserialize<JsonObject>(lastConfigStr);
12861286

@@ -1343,7 +1343,7 @@ public async Task GetFeatureFlagAttribute_WhenHasAttribute_ReturnsAttributeValue
13431343
attributeTwo = 20
13441344
},
13451345
};
1346-
1346+
13471347
var lastConfigStr = JsonSerializer.Serialize(lastConfig);
13481348
var transformedValue = JsonSerializer.Deserialize<JsonObject>(lastConfigStr);
13491349

@@ -1373,14 +1373,16 @@ public async Task GetFeatureFlagAttribute_WhenHasAttribute_ReturnsAttributeValue
13731373
.WithConfigProfile(configProfileId);
13741374

13751375
// Act
1376-
var attributeValue1 = await appConfigProvider.GetFeatureFlagAttributeValueAsync<string>("FeatureFlagOne", "attributeOne").ConfigureAwait(false);
1377-
var attributeValue2 = await appConfigProvider.GetFeatureFlagAttributeValueAsync<int>("FeatureFlagOne", "attributeTwo").ConfigureAwait(false);
1376+
var attributeValue1 = await appConfigProvider
1377+
.GetFeatureFlagAttributeValueAsync<string>("FeatureFlagOne", "attributeOne").ConfigureAwait(false);
1378+
var attributeValue2 = await appConfigProvider
1379+
.GetFeatureFlagAttributeValueAsync<int>("FeatureFlagOne", "attributeTwo").ConfigureAwait(false);
13781380

13791381
// Assert
13801382
Assert.Equal(attributeValue1, lastConfig.FeatureFlagOne.attributeOne);
13811383
Assert.Equal(attributeValue2, lastConfig.FeatureFlagOne.attributeTwo);
13821384
}
1383-
1385+
13841386
[Fact]
13851387
public async Task GetFeatureFlagAttribute_WhenAttributeDoesNotExist_ReturnsNull()
13861388
{
@@ -1408,7 +1410,7 @@ public async Task GetFeatureFlagAttribute_WhenAttributeDoesNotExist_ReturnsNull(
14081410
attributeTwo = 20
14091411
},
14101412
};
1411-
1413+
14121414
var lastConfigStr = JsonSerializer.Serialize(lastConfig);
14131415
var transformedValue = JsonSerializer.Deserialize<JsonObject>(lastConfigStr);
14141416

@@ -1438,12 +1440,13 @@ public async Task GetFeatureFlagAttribute_WhenAttributeDoesNotExist_ReturnsNull(
14381440
.WithConfigProfile(configProfileId);
14391441

14401442
// Act
1441-
var attributeValue1 = await appConfigProvider.GetFeatureFlagAttributeValueAsync<string>("FeatureFlagOne", "INVALID").ConfigureAwait(false);
1443+
var attributeValue1 = await appConfigProvider
1444+
.GetFeatureFlagAttributeValueAsync<string>("FeatureFlagOne", "INVALID").ConfigureAwait(false);
14421445

14431446
// Assert
14441447
Assert.Null(attributeValue1);
14451448
}
1446-
1449+
14471450
[Fact]
14481451
public async Task GetFeatureFlagAttribute_WhenAttributeDoesNotExist_ReturnsSpecifiedDefaultValue()
14491452
{
@@ -1472,7 +1475,7 @@ public async Task GetFeatureFlagAttribute_WhenAttributeDoesNotExist_ReturnsSpeci
14721475
attributeTwo = 20
14731476
},
14741477
};
1475-
1478+
14761479
var lastConfigStr = JsonSerializer.Serialize(lastConfig);
14771480
var transformedValue = JsonSerializer.Deserialize<JsonObject>(lastConfigStr);
14781481

@@ -1502,7 +1505,8 @@ public async Task GetFeatureFlagAttribute_WhenAttributeDoesNotExist_ReturnsSpeci
15021505
.WithConfigProfile(configProfileId);
15031506

15041507
// Act
1505-
var attributeValue1 = await appConfigProvider.GetFeatureFlagAttributeValueAsync<string>("FeatureFlagOne", "INVALID", defaultAttributeVale).ConfigureAwait(false);
1508+
var attributeValue1 = await appConfigProvider
1509+
.GetFeatureFlagAttributeValueAsync("FeatureFlagOne", "INVALID", defaultAttributeVale).ConfigureAwait(false);
15061510

15071511
// Assert
15081512
Assert.Equal(attributeValue1, defaultAttributeVale);

0 commit comments

Comments
 (0)