Sonar fixes.

Author: lachriz-aws

examples/BatchProcessing/template.yaml

@@ -96,6 +96,12 @@ Resources:
               - ReportBatchItemFailures
             Queue: !GetAtt SqsQueue.Arn
 
+  SqsBatchProcessorFunctionLogGroup:
+    Type: AWS::Logs::LogGroup
+    Properties:
+      LogGroupName: !Sub "/aws/lambda/${SqsBatchProcessorFunction}"
+      RetentionInDays: 7
+
   # --------------
   # Batch Processing for DynamoDb (DDB) Stream
   DdbStreamDeadLetterQueue:
@@ -116,7 +122,7 @@ Resources:
       StreamSpecification:
         StreamViewType: NEW_AND_OLD_IMAGES
 
-  DdbStreamProcessorFunction:
+  DdbStreamBatchProcessorFunction:
     Type: AWS::Serverless::Function
     Properties:
       CodeUri: ./src/HelloWorld/
@@ -152,6 +158,12 @@ Resources:
             StartingPosition: LATEST
             Stream: !GetAtt DdbTable.StreamArn
 
+  DdbStreamBatchProcessorFunctionLogGroup:
+    Type: AWS::Logs::LogGroup
+    Properties:
+      LogGroupName: !Sub "/aws/lambda/${DdbStreamBatchProcessorFunction}"
+      RetentionInDays: 7
+
   # --------------
   # Batch Processing for Kinesis Data Stream
   KinesisStreamDeadLetterQueue:
@@ -215,6 +227,12 @@ Resources:
             StartingPosition: LATEST
             Stream: !GetAtt KinesisStreamConsumer.ConsumerARN
 
+  KinesisBatchProcessorFunctionLogGroup:
+    Type: AWS::Logs::LogGroup
+    Properties:
+      LogGroupName: !Sub "/aws/lambda/${KinesisBatchProcessorFunction}"
+      RetentionInDays: 7
+
 Outputs:
   SqsQueueUrl:
     Description: "SQS Queue URL"

libraries/src/AWS.Lambda.Powertools.BatchProcessing/BatchProcessorAttribute.cs

@@ -133,44 +133,44 @@ public class BatchProcessorAttribute : UniversalWrapperAttribute
     /// <summary>
     /// Type of batch processor.
     /// </summary>
-    public Type BatchProcessor;
+    public Type BatchProcessor { get; set; }
 
     /// <summary>
     /// Type of batch processor provider.
     /// </summary>
-    public Type BatchProcessorProvider;
+    public Type BatchProcessorProvider { get; set; }
 
     /// <summary>
     /// Type of record handler.
     /// </summary>
-    public Type RecordHandler;
+    public Type RecordHandler { get; set; }
 
     /// <summary>
     /// Type of record handler provider.
     /// </summary>
-    public Type RecordHandlerProvider;
+    public Type RecordHandlerProvider { get; set; }
 
     /// <summary>
     /// Error handling policy.
     /// </summary>
-    public BatchProcessorErrorHandlingPolicy ErrorHandlingPolicy;
+    public BatchProcessorErrorHandlingPolicy ErrorHandlingPolicy { get; set; }
 
     /// <summary>
     /// Batch processing enabled (default false)
     /// </summary>
-    public bool BatchParallelProcessingEnabled = PowertoolsConfigurations.Instance.BatchParallelProcessingEnabled;
+    public bool BatchParallelProcessingEnabled { get; set; } = PowertoolsConfigurations.Instance.BatchParallelProcessingEnabled;
 
     /// <summary>
     /// The maximum degree of parallelism to apply during batch processing.
     /// Must enable BatchParallelProcessingEnabled
     /// </summary>
-    public int MaxDegreeOfParallelism = PowertoolsConfigurations.Instance.BatchProcessingMaxDegreeOfParallelism;
+    public int MaxDegreeOfParallelism { get; set; } = PowertoolsConfigurations.Instance.BatchProcessingMaxDegreeOfParallelism;
 
-    /// <summary>
+    /// <summary>
     /// By default, the Batch processor throws a <see cref="BatchProcessingException"/> on full batch failure.
-    /// This behaviour can be disabled by setting this value to false.
+    /// This behaviour can be disabled by setting this value to false.
     /// </summary>
-    public bool ThrowOnFullBatchFailure = PowertoolsConfigurations.Instance.BatchThrowOnFullBatchFailureEnabled;
+    public bool ThrowOnFullBatchFailure { get; set; } = PowertoolsConfigurations.Instance.BatchThrowOnFullBatchFailureEnabled;
 
     private static readonly Dictionary<Type, BatchEventType> EventTypes = new()
     {