Skip to content

Commit 7f4d676

Browse files
committed
more test coverage
1 parent e34c389 commit 7f4d676

File tree

1 file changed

+23
-8
lines changed

1 file changed

+23
-8
lines changed

libraries/tests/AWS.Lambda.Powertools.Metrics.Tests/SerializationTests.cs

Lines changed: 23 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,25 @@ public void Metrics_Resolution_JsonConverter()
1313
// Arrange
1414
var options = new JsonSerializerOptions();
1515
options.Converters.Add(new MetricResolutionJsonConverter());
16-
16+
17+
{
18+
var myInt = JsonSerializer.Deserialize<MetricResolution>(1, options);
19+
Assert.Equal(MetricResolution.High, myInt);
20+
Assert.Equal("1", JsonSerializer.Serialize(myInt, options));
21+
}
22+
1723
{
1824
var myInt = JsonSerializer.Deserialize<MetricResolution>("1", options);
1925
Assert.Equal(MetricResolution.High, myInt);
2026
Assert.Equal("1", JsonSerializer.Serialize(myInt, options));
2127
}
22-
28+
2329
{
2430
var myInt = JsonSerializer.Deserialize<MetricResolution>("60", options);
2531
Assert.Equal(MetricResolution.Standard, myInt);
2632
Assert.Equal("60", JsonSerializer.Serialize(myInt, options));
2733
}
28-
34+
2935
{
3036
var myInt = JsonSerializer.Deserialize<MetricResolution>("0", options);
3137
Assert.Equal(MetricResolution.Default, myInt);
@@ -48,18 +54,27 @@ public void Metrics_Resolution_JsonConverter()
4854
Assert.Equal("0", JsonSerializer.Serialize(myInt, options));
4955
}
5056
}
51-
57+
5258
[Fact]
5359
public void Metrics_Resolution_JsonConverter_Exception()
5460
{
5561
// Arrange
5662
var options = new JsonSerializerOptions();
5763
options.Converters.Add(new MetricResolutionJsonConverter());
64+
65+
{
66+
Action act = () => JsonSerializer.Deserialize<MetricResolution>("1.3", options);
67+
Assert.Throws<JsonException>(act);
68+
}
5869

59-
// Act
60-
Action act = () => JsonSerializer.Deserialize<MetricResolution>("abd", options);
70+
{
71+
Action act = () => JsonSerializer.Deserialize<MetricResolution>(@"""1.3""", options);
72+
Assert.Throws<JsonException>(act);
73+
}
6174

62-
// Assert
63-
Assert.Throws<JsonException>(act);
75+
{
76+
Action act = () => JsonSerializer.Deserialize<MetricResolution>(@"""abc""", options);
77+
Assert.Throws<JsonException>(act);
78+
}
6479
}
6580
}

0 commit comments

Comments
 (0)