Clean-up pom dependencies and remove awssdk#StringUtils usage

Author: eldimi

powertools-idempotency/pom.xml

@@ -48,20 +48,6 @@
             <groupId>software.amazon.lambda</groupId>
             <artifactId>powertools-common</artifactId>
         </dependency>
-        <dependency>
-            <groupId>software.amazon.lambda</groupId>
-            <artifactId>powertools-serialization</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>com.amazonaws</groupId>
-            <artifactId>aws-lambda-java-core</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>software.amazon.awssdk</groupId>
-            <artifactId>url-connection-client</artifactId>
-            <version>${aws.sdk.version}</version>
-        </dependency>
-
         <!-- Test dependencies -->
         <dependency>
             <groupId>org.junit.jupiter</groupId>

powertools-idempotency/powertools-idempotency-core/pom.xml

@@ -27,7 +27,7 @@
     <artifactId>powertools-idempotency-core</artifactId>
     <packaging>jar</packaging>
 
-    <name>Powertools for AWS Lambda (Java) library Idempotency - Common</name>
+    <name>Powertools for AWS Lambda (Java) library Idempotency - Core</name>
     <description>
         Idempotency module common implementation
     </description>
@@ -37,15 +37,6 @@
             <groupId>software.amazon.lambda</groupId>
             <artifactId>powertools-serialization</artifactId>
         </dependency>
-        <dependency>
-            <groupId>com.amazonaws</groupId>
-            <artifactId>aws-lambda-java-core</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>software.amazon.awssdk</groupId>
-            <artifactId>url-connection-client</artifactId>
-            <version>${aws.sdk.version}</version>
-        </dependency>
         <!-- Test dependencies -->
     </dependencies>
 </project>

powertools-idempotency/powertools-idempotency-core/src/main/java/software/amazon/lambda/powertools/idempotency/persistence/BasePersistenceStore.java

@@ -20,7 +20,6 @@
 import io.burt.jmespath.Expression;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import software.amazon.awssdk.utils.StringUtils;
 import software.amazon.lambda.powertools.idempotency.IdempotencyConfig;
 import software.amazon.lambda.powertools.idempotency.exceptions.IdempotencyItemAlreadyExistsException;
 import software.amazon.lambda.powertools.idempotency.exceptions.IdempotencyItemNotFoundException;
@@ -74,7 +73,7 @@ public abstract class BasePersistenceStore implements PersistenceStore {
     public void configure(IdempotencyConfig config, String functionName) {
         String funcEnv = System.getenv(LAMBDA_FUNCTION_NAME_ENV);
         this.functionName = funcEnv != null ? funcEnv : "testFunction";
-        if (!StringUtils.isEmpty(functionName)) {
+        if (functionName != null && !functionName.isEmpty()) {
             this.functionName += "." + functionName;
         }
 
@@ -340,7 +339,7 @@ private MessageDigest getHashAlgorithm() {
     private void validatePayload(JsonNode data, DataRecord dataRecord) throws IdempotencyValidationException {
         if (payloadValidationEnabled) {
             String dataHash = getHashedPayload(data);
-            if (!StringUtils.equals(dataHash, dataRecord.getPayloadHash())) {
+            if (!isEqual(dataRecord.getPayloadHash(), dataHash)) {
                 throw new IdempotencyValidationException("Payload does not match stored record for this event key");
             }
         }
@@ -403,4 +402,12 @@ void configure(IdempotencyConfig config, String functionName, LRUCache<String, D
         this.configure(config, functionName);
         this.cache = cache;
     }
+
+    private static boolean isEqual(String dataRecordPayload, String dataHash) {
+        if (dataHash != null && dataRecordPayload != null) {
+            return dataHash.length() != dataRecordPayload.length() ? false : dataHash.equals(dataRecordPayload);
+        } else {
+            return false;
+        }
+    }
 }

powertools-idempotency/powertools-idempotency-dynamodb/pom.xml

@@ -38,6 +38,11 @@
             <artifactId>powertools-idempotency-core</artifactId>
             <version>${project.version}</version>
         </dependency>
+        <dependency>
+            <groupId>software.amazon.awssdk</groupId>
+            <artifactId>url-connection-client</artifactId>
+            <version>${aws.sdk.version}</version>
+        </dependency>
         <dependency>
             <groupId>software.amazon.awssdk</groupId>
             <artifactId>dynamodb</artifactId>

powertools-idempotency/powertools-idempotency-dynamodb/src/main/java/software/amazon/lambda/powertools/idempotency/persistence/dynamodb/DynamoDBPersistenceStore.java

@@ -28,7 +28,6 @@
 import software.amazon.awssdk.services.dynamodb.model.GetItemResponse;
 import software.amazon.awssdk.services.dynamodb.model.PutItemRequest;
 import software.amazon.awssdk.services.dynamodb.model.UpdateItemRequest;
-import software.amazon.awssdk.utils.StringUtils;
 import software.amazon.lambda.powertools.common.internal.UserAgentConfigurator;
 import software.amazon.lambda.powertools.idempotency.Constants;
 import software.amazon.lambda.powertools.idempotency.exceptions.IdempotencyItemAlreadyExistsException;
@@ -314,7 +313,7 @@ public static class Builder {
          * @return an instance of the {@link DynamoDBPersistenceStore}
          */
         public DynamoDBPersistenceStore build() {
-            if (StringUtils.isEmpty(tableName)) {
+            if (tableName == null || "".equals(tableName)) {
                 throw new IllegalArgumentException("Table name is not specified");
             }
             return new DynamoDBPersistenceStore(tableName, keyAttr, staticPkValue, sortKeyAttr, expiryAttr,