Skip to content

Commit dd817bb

Browse files
eldimiscottgerring
eldimi
authored and
scottgerring
committed
fix spotbugs for multiple modules - multiple spotbugs files
1 parent d0031c9 commit dd817bb

File tree

14 files changed

+50
-48
lines changed

14 files changed

+50
-48
lines changed

‎powertools-batch/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@
2626

2727
<artifactId>powertools-batch</artifactId>
2828

29-
<properties>
30-
<parentproject.basedir>${project.parent.basedir}</parentproject.basedir>
31-
</properties>
32-
3329
<dependencies>
3430
<dependency>
3531
<groupId>com.amazonaws</groupId>

‎powertools-cloudformation/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@
3333
custom metrics asynchronously easier.
3434
</description>
3535

36-
<properties>
37-
<parentproject.basedir>${project.parent.basedir}</parentproject.basedir>
38-
</properties>
39-
4036
<dependencies>
4137
<dependency>
4238
<groupId>software.amazon.awssdk</groupId>

‎powertools-common/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@
3030
<name>Powertools for AWS Lambda (Java) - Common Internal Utilities</name>
3131
<description>Internal utilities shared by the Powertools for AWS Lambda (Java) modules. Do not use directly in your project.</description>
3232

33-
<properties>
34-
<parentproject.basedir>${project.parent.basedir}</parentproject.basedir>
35-
</properties>
36-
3733
<dependencies>
3834
<dependency>
3935
<groupId>org.slf4j</groupId>

‎powertools-idempotency/powertools-idempotency-core/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@
3232
Idempotency module common implementation
3333
</description>
3434

35-
<properties>
36-
<parentproject.basedir>${project.parent.parent.basedir}</parentproject.basedir>
37-
</properties>
38-
3935
<dependencies>
4036
<dependency>
4137
<groupId>software.amazon.lambda</groupId>

‎powertools-idempotency/powertools-idempotency-dynamodb/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@
3232
DynamoDB implementation for the idempotency module
3333
</description>
3434

35-
<properties>
36-
<parentproject.basedir>${project.parent.parent.basedir}</parentproject.basedir>
37-
</properties>
38-
3935
<dependencies>
4036
<dependency>
4137
<groupId>software.amazon.lambda</groupId>

‎powertools-idempotency/spotbugs-exclude.xml

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
<!-- This file specifies a spotbugs filter for excluding reports that
2+
should not be considered errors.
3+
The format of this file is documented at:
4+
https://spotbugs.readthedocs.io/en/latest/filter.html
5+
When possible, please specify the full names of the bug codes,
6+
using the pattern attribute, to make it clearer what reports are
7+
being suppressed. You can find a listing of codes at:
8+
https://spotbugs.readthedocs.io/en/latest/bugDescriptions.html
9+
-->
10+
<FindBugsFilter>
11+
<!-- Internals of Log event for apache log4j-->
12+
<Match>
13+
<Bug pattern="EI_EXPOSE_REP"/>
14+
<Or>
15+
<And>
16+
<Class name="software.amazon.lambda.powertools.idempotency.Idempotency"/>
17+
<Method name="getPersistenceStore"/>
18+
</And>
19+
<And>
20+
<Class name="software.amazon.lambda.powertools.idempotency.Idempotency"/>
21+
<Method name="getConfig"/>
22+
</And>
23+
</Or>
24+
</Match>
25+
<Match>
26+
<Bug pattern="EI_EXPOSE_REP2"/>
27+
<Or>
28+
<And>
29+
<Class name="software.amazon.lambda.powertools.idempotency.Idempotency$Config"/>
30+
<Field name="store"/>
31+
</And>
32+
<And>
33+
<Class name="software.amazon.lambda.powertools.idempotency.Idempotency$Config"/>
34+
<Field name="config"/>
35+
</And>
36+
<And>
37+
<Class name="software.amazon.lambda.powertools.idempotency.internal.IdempotencyHandler"/>
38+
<Field name="pjp"/>
39+
</And>
40+
<And>
41+
<Class name="software.amazon.lambda.powertools.idempotency.persistence.dynamodb.DynamoDBPersistenceStore$Builder"/>
42+
<Field name="dynamoDbClient"/>
43+
</And>
44+
</Or>
45+
</Match>
46+
</FindBugsFilter>

‎powertools-large-messages/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@
3131

3232
<name>Powertools for AWS Lambda (Java) - Large messages</name>
3333

34-
<properties>
35-
<parentproject.basedir>${project.parent.basedir}</parentproject.basedir>
36-
</properties>
37-
3834
<dependencies>
3935
<dependency>
4036
<groupId>org.aspectj</groupId>

‎powertools-logging/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@
2929
<artifactId>powertools-logging</artifactId>
3030
<packaging>jar</packaging>
3131

32-
<properties>
33-
<parentproject.basedir>${project.parent.basedir}</parentproject.basedir>
34-
</properties>
35-
3632
<dependencies>
3733
<dependency>
3834
<groupId>software.amazon.lambda</groupId>

‎powertools-metrics/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@
3333
asynchronously easier.
3434
</description>
3535

36-
<properties>
37-
<parentproject.basedir>${project.parent.basedir}</parentproject.basedir>
38-
</properties>
39-
4036
<dependencies>
4137
<dependency>
4238
<groupId>org.aspectj</groupId>

‎powertools-parameters/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@
2929
<name>Powertools for AWS Lambda (Java) - Parameters</name>
3030
<description>Set of utilities to retrieve parameters - common interface</description>
3131

32-
<properties>
33-
<parentproject.basedir>${project.parent.basedir}</parentproject.basedir>
34-
</properties>
35-
3632
<dependencies>
3733
<dependency>
3834
<groupId>org.aspectj</groupId>

‎powertools-serialization/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@
3232

3333
</description>
3434

35-
<properties>
36-
<parentproject.basedir>${project.parent.basedir}</parentproject.basedir>
37-
</properties>
38-
3935
<dependencies>
4036
<dependency>
4137
<groupId>io.burt</groupId>

‎powertools-tracing/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@
3232
A suite of utilities for AWS Lambda Functions that makes tracing with AWS X-Ray, structured logging and creating custom metrics asynchronously easier.
3333
</description>
3434

35-
<properties>
36-
<parentproject.basedir>${project.parent.basedir}</parentproject.basedir>
37-
</properties>
38-
3935
<dependencies>
4036
<dependency>
4137
<groupId>org.aspectj</groupId>

‎powertools-validation/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@
3232
Json schema validation for Lambda events and responses
3333
</description>
3434

35-
<properties>
36-
<parentproject.basedir>${project.parent.basedir}</parentproject.basedir>
37-
</properties>
38-
3935
<dependencies>
4036
<dependency>
4137
<groupId>software.amazon.lambda</groupId>

‎spotbugs-exclude.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
<Field name="transformationManager"/>
2929
</And>
3030
<And>
31+
<Class name="software.amazon.lambda.powertools.largemessages.LargeMessageConfig"/>
32+
<Method name="getS3Client"/>
3133
<Class name="software.amazon.lambda.powertools.parameters.secrets.SecretsProviderBuilder"/>
3234
<Field name="cacheManager"/>
3335
</And>
@@ -107,6 +109,8 @@
107109
<Field name="throwableConverter"/>
108110
</And>
109111
<And>
112+
<Class name="software.amazon.lambda.powertools.parameters.transform.TransformationManager"/>
113+
<Field name="transformer"/>
110114
<Class name="software.amazon.lambda.powertools.logging.logback.LambdaEcsEncoder"/>
111115
<Field name="throwableConverter"/>
112116
</And>

0 commit comments

Comments
 (0)