Skip to content

Commit 931ba6f

Browse files
committed
fix(parser): properly parse eventbridge envelope when using safeParse
Currently, the EventBridgeEnvelope.safeParse method only validates, it does not parse the data provided in the typing system. Small fix utilizing existing typing generics that weren't being assigned.
1 parent f93deba commit 931ba6f

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

packages/parser/src/envelopes/envelope.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const Envelope = {
3535
* @param input
3636
* @param schema
3737
*/
38-
safeParse<T extends ZodSchema>(input: unknown, schema: T): ParsedResult {
38+
safeParse<T extends ZodSchema>(input: unknown, schema: T): ParsedResult<unknown, T> {
3939
try {
4040
if (typeof input !== 'object' && typeof input !== 'string') {
4141
return {
@@ -52,13 +52,13 @@ const Envelope = {
5252

5353
return parsed.success
5454
? {
55-
success: true,
56-
data: parsed.data,
57-
}
55+
success: true,
56+
data: parsed.data,
57+
}
5858
: {
59-
success: false,
60-
error: parsed.error,
61-
};
59+
success: false,
60+
error: parsed.error,
61+
};
6262
} catch (e) {
6363
return {
6464
success: false,

packages/parser/src/envelopes/event-bridge.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const EventBridgeEnvelope = {
1717
return Envelope.parse(EventBridgeSchema.parse(data).detail, schema);
1818
},
1919

20-
safeParse<T extends ZodSchema>(data: unknown, schema: T): ParsedResult {
20+
safeParse<T extends ZodSchema>(data: unknown, schema: T): ParsedResult<unknown, T> {
2121
const parsedEnvelope = EventBridgeSchema.safeParse(data);
2222

2323
if (!parsedEnvelope.success) {

0 commit comments

Comments
 (0)