Skip to content

feat: Implement Ranged-Get #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 7, 2022
Merged

feat: Implement Ranged-Get #31

merged 6 commits into from
Nov 7, 2022

Conversation

imabhichow
Copy link
Contributor

@imabhichow imabhichow commented Nov 1, 2022 •
edited
Loading

Issue #, if available:

Description of changes:

  • Implement Ranged-get for AES/CBC/PKCS5Padding
  • Implement Ranged-get for AES/CTR/NoPadding
  • Add test cases for ranged-gets

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

kessplas
kessplas requested changes Nov 2, 2022
View reviewed changes
kessplas
kessplas approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@kessplas kessplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! Approved with some nits. Feel free to merge now or fix then merge.

@imabhichow imabhichow merged commit 65331fb into main Nov 7, 2022
@imabhichow imabhichow deleted the ranged-get-stream branch November 7, 2022 18:54
aws-crypto-tools-ci-bot pushed a commit that referenced this pull request Dec 2, 2022
@semantic-release-bot
AWS S3 Encryption Client 1.0.0 Release -- $(date +%Y-%m-%d)
f596953 
## 1.0.0 (2022-12-02)

### Features

* Adds CBC stream decryption ([#25](#25)) ([9970104](9970104))
* Configurable SecureRandom ([#40](#40)) ([90cab2d](90cab2d))
* Implement Ranged-Get ([#31](#31)) ([65331fb](65331fb))
* Introduce delayed authentication ([#23](#23)) ([b8eedac](b8eedac))

### Fixes

* Guard against using another S3EC as wrappedClient ([#36](#36)) ([30cf9b1](30cf9b1))

### Maintenance

* Add staging release and validation ([1e0c4cd](1e0c4cd))
aws-crypto-tools-ci-bot pushed a commit that referenced this pull request Dec 2, 2022
@semantic-release-bot
AWS S3 Encryption Client 1.0.0 Release -- $(date +%Y-%m-%d)
c04bf8f 
## 1.0.0 (2022-12-02)

### Features

* Adds CBC stream decryption ([#25](#25)) ([9970104](9970104))
* Configurable SecureRandom ([#40](#40)) ([90cab2d](90cab2d))
* Implement Ranged-Get ([#31](#31)) ([65331fb](65331fb))
* Introduce delayed authentication ([#23](#23)) ([b8eedac](b8eedac))

### Fixes

* Guard against using another S3EC as wrappedClient ([#36](#36)) ([30cf9b1](30cf9b1))

### Maintenance

* Add staging release and validation ([1e0c4cd](1e0c4cd))
aws-crypto-tools-ci-bot pushed a commit that referenced this pull request Dec 2, 2022
@semantic-release-bot
AWS S3 Encryption Client 1.0.0 Release -- $(date +%Y-%m-%d)
83f0345 
## 1.0.0 (2022-12-02)

### Features

* Adds CBC stream decryption ([#25](#25)) ([9970104](9970104))
* Configurable SecureRandom ([#40](#40)) ([90cab2d](90cab2d))
* Implement Ranged-Get ([#31](#31)) ([65331fb](65331fb))
* Introduce delayed authentication ([#23](#23)) ([b8eedac](b8eedac))

### Fixes

* Guard against using another S3EC as wrappedClient ([#36](#36)) ([30cf9b1](30cf9b1))

### Maintenance

* Add staging release and validation ([1e0c4cd](1e0c4cd))
aws-crypto-tools-ci-bot pushed a commit that referenced this pull request Dec 2, 2022
@semantic-release-bot
AWS S3 Encryption Client 1.0.0 Release -- $(date +%Y-%m-%d)
3ff3d9a 
## 1.0.0 (2022-12-02)

### Features

* Adds CBC stream decryption ([#25](#25)) ([9970104](9970104))
* Configurable SecureRandom ([#40](#40)) ([90cab2d](90cab2d))
* Implement Ranged-Get ([#31](#31)) ([65331fb](65331fb))
* Introduce delayed authentication ([#23](#23)) ([b8eedac](b8eedac))

### Fixes

* Guard against using another S3EC as wrappedClient ([#36](#36)) ([30cf9b1](30cf9b1))

### Maintenance

* Add staging release and validation ([1e0c4cd](1e0c4cd))
aws-crypto-tools-ci-bot pushed a commit that referenced this pull request Dec 2, 2022
@semantic-release-bot
AWS S3 Encryption Client 1.0.0 Release -- $(date +%Y-%m-%d)
6a61e7f 
## 1.0.0 (2022-12-02)

### Features

* Adds CBC stream decryption ([#25](#25)) ([9970104](9970104))
* Configurable SecureRandom ([#40](#40)) ([90cab2d](90cab2d))
* Implement Ranged-Get ([#31](#31)) ([65331fb](65331fb))
* Introduce delayed authentication ([#23](#23)) ([b8eedac](b8eedac))

### Fixes

* Guard against using another S3EC as wrappedClient ([#36](#36)) ([30cf9b1](30cf9b1))

### Maintenance

* Add staging release and validation ([1e0c4cd](1e0c4cd))
aws-crypto-tools-ci-bot pushed a commit that referenced this pull request Dec 2, 2022
@semantic-release-bot
AWS S3 Encryption Client 1.0.0 Release -- $(date +%Y-%m-%d)
9953a2a 
## 1.0.0 (2022-12-02)

### Features

* Adds CBC stream decryption ([#25](#25)) ([9970104](9970104))
* Configurable SecureRandom ([#40](#40)) ([90cab2d](90cab2d))
* Implement Ranged-Get ([#31](#31)) ([65331fb](65331fb))
* Introduce delayed authentication ([#23](#23)) ([b8eedac](b8eedac))

### Fixes

* Guard against using another S3EC as wrappedClient ([#36](#36)) ([30cf9b1](30cf9b1))

### Maintenance

* Add staging release and validation ([1e0c4cd](1e0c4cd))
aws-crypto-tools-ci-bot pushed a commit that referenced this pull request Feb 18, 2023
@semantic-release-bot
AWS S3 Encryption Client 1.0.0 Release -- $(date +%Y-%m-%d)
d0b2902 
## 1.0.0 (2023-02-18)

### Features

* Adds Async client, starting with DeleteObject(s) ([#54](#54)) ([c7120e1](c7120e1))
* Adds CBC stream decryption ([#25](#25)) ([9970104](9970104))
* Configurable SecureRandom ([#40](#40)) ([90cab2d](90cab2d))
* implement AES-GCM streaming ([#45](#45)) ([d0bcd38](d0bcd38))
* implement CBC decryption in async getObject ([#59](#59)) ([4fd2fa8](4fd2fa8))
* implement getObject async ([#56](#56)) ([b9834ce](b9834ce))
* implement putObject in Async client  ([#57](#57)) ([f233d72](f233d72))
* Implement Ranged-Get ([#31](#31)) ([65331fb](65331fb))
* Introduce delayed authentication ([#23](#23)) ([b8eedac](b8eedac))
* multi-part putObject ([#53](#53)) ([281f383](281f383))
* Multipart Upload ([#43](#43)) ([7e42811](7e42811))

### Maintenance

* Create workflow to release S3EC to Github ([#52](#52)) ([ef8effb](ef8effb))

### Fixes

* add instruction file support in getObject async ([#69](#69)) ([ee61abd](ee61abd))
* address some edge cases to fix async CBC ranged gets ([#70](#70)) ([1da1cae](1da1cae))
* Guard against using another S3EC as wrappedClient ([#36](#36)) ([30cf9b1](30cf9b1))
aws-crypto-tools-ci-bot pushed a commit that referenced this pull request Feb 20, 2023
@semantic-release-bot
AWS S3 Encryption Client 1.0.0 Release -- $(date +%Y-%m-%d)
7795043 
## 1.0.0 (2023-02-20)

### Features

* Adds Async client, starting with DeleteObject(s) ([#54](#54)) ([c7120e1](c7120e1))
* Adds CBC stream decryption ([#25](#25)) ([9970104](9970104))
* Configurable SecureRandom ([#40](#40)) ([90cab2d](90cab2d))
* implement AES-GCM streaming ([#45](#45)) ([d0bcd38](d0bcd38))
* implement CBC decryption in async getObject ([#59](#59)) ([4fd2fa8](4fd2fa8))
* implement getObject async ([#56](#56)) ([b9834ce](b9834ce))
* implement putObject in Async client  ([#57](#57)) ([f233d72](f233d72))
* Implement Ranged-Get ([#31](#31)) ([65331fb](65331fb))
* Introduce delayed authentication ([#23](#23)) ([b8eedac](b8eedac))
* multi-part putObject ([#53](#53)) ([281f383](281f383))
* Multipart Upload ([#43](#43)) ([7e42811](7e42811))

### Maintenance

* Create workflow to release S3EC to Github ([#52](#52)) ([ef8effb](ef8effb))

### Fixes

* add instruction file support in getObject async ([#69](#69)) ([ee61abd](ee61abd))
* address some edge cases to fix async CBC ranged gets ([#70](#70)) ([1da1cae](1da1cae))
* Guard against using another S3EC as wrappedClient ([#36](#36)) ([30cf9b1](30cf9b1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kessplas kessplas kessplas approved these changes

@seebees seebees Awaiting requested review from seebees

@texastony texastony Awaiting requested review from texastony

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imabhichow @kessplas